This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
feat: remove unnecessary bypass for URL inputs on link editor #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommoor
reviewed
Sep 11, 2020
| event.preventDefault(); | ||
| event.stopPropagation(); | ||
| const prevIndex = this.state.selectedIndex - 1; | ||
|
|
||
| this.setState({ | ||
| selectedIndex: Math.max(0, prevIndex), | ||
| selectedIndex: Math.max(-1, prevIndex), |
There was a problem hiding this comment.
it changes the key semantics of the search box to be similar to google (as well as many other search / type-ahead interfaces), where pressing up at the top item puts you back into the editor.
The world is about 50-50 on this behavior but the products that think about UI more intently generally do it this way IMO. It feels right to me
thenanyu
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required to address outline/outline#1527