Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

fix: Safari hangs when selecting a cell in an empty table #322

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

tommoor
Copy link
Member

@tommoor tommoor commented Nov 11, 2020

Move grip rendering to a pseudo class to work around a long standing issue with Safari/Prosemirror that causes the browser to hang in an empty table. These changes have been tested in Chrome, Safari, and Firefox.

image

closes outline/outline#1647
related ProseMirror/prosemirror#947

@tommoor tommoor changed the title fixes: Safari hangs when selecting a cell in an empty table fix: Safari hangs when selecting a cell in an empty table Nov 11, 2020

/* fixes Firefox background color painting over border:
* https://bugzilla.mozilla.org/show_bug.cgi?id=688556 */
background-clip: padding-box;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but I spotted this while testing Firefox.

@tommoor tommoor merged commit b0be879 into develop Nov 12, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/issue-1647 branch November 12, 2020 05:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Columns/Lines on Table in a Mac Computer using Safari Freeze the Page
1 participant