Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Numpy: numpy<2.0.0, Prevent ModuleNotFoundError #977

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

lapp0
Copy link
Collaborator

@lapp0 lapp0 commented Jun 16, 2024

Addresses: #976

Fixes vllm-project/vllm#5582

We should close 976 after we fix Outlines to be compatible with Numpy >= 2.0.0, which this PR doesn't do.

Problem

Cannot import outlines due to outlines/base.py importing from numpy.lib.function_base import ( which no longer exists in numpy 2.0.0.

Temporary Solution

Pin numpy<2.0.0

@glibg10b
Copy link

Major revision bumps (1.x.x -> 2.x.x) always have breaking changes. Should the other requirements not be limited in this way as well?

That would have to wait, though. This issue affects all scripts and modules that import outlines, and should be merged ASAP.

@lapp0
Copy link
Collaborator Author

lapp0 commented Jun 17, 2024

Major revision bumps (1.x.x -> 2.x.x) always have breaking changes. Should the other requirements not be limited in this way as well?

That would have to wait, though. This issue affects all scripts and modules that import outlines, and should be merged ASAP.

Good idea, I created an issue for that #981

@rlouf rlouf merged commit 6a2e6af into outlines-dev:main Jun 17, 2024
7 checks passed
@WoosukKwon
Copy link

Hi @rlouf, could you please make a new release? vLLM imports outlines for the OpenAI server and is currently broken because of this Numpy issue.

@rlouf
Copy link
Member

rlouf commented Jun 17, 2024

Will do right now

@WoosukKwon
Copy link

@rlouf Thanks a lot!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants