Collect examples from model definitions #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outofcoffee
requested changes
Aug 22, 2017
There was a problem hiding this comment.
This is great, thank you.
For the test spec, please could we have a slimmed down version that just contains the definitions needed to test the new functionality? I'd like to avoid reusing the sample as it will likely be overwritten periodically as we update it in future.
As far as the test itself is concerned; please could we split this into a separate test method?
outofcoffee
force-pushed
the
master
branch
2 times, most recently
from
ae27d1f
to
9416f2a
Compare
This was referenced Aug 4, 2019
|
Experimental support added in 65d343c. Enable with |
outofcoffee
force-pushed
the
master
branch
3 times, most recently
from
62a0786
to
d5171f1
Compare
|
Superseded by #40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably more cases to be covered