Skip to content

Commit

Permalink
Fix for suspended domain checking while LE renewing
Browse files Browse the repository at this point in the history
Logic should be inversed...
If you grep for suspended=no, then variable is NOT empty if it's NOT suspended
Which means it's empty only if it's suspended.
So we must grep for suspended=yes if we consider not-empty result as suspended domain.
@skullwritter 

This bug totally brakes LE renewing :)
  • Loading branch information
dpeca committed Dec 10, 2018
1 parent 320455f commit 58c6ca9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bin/v-update-letsencrypt-ssl
Expand Up @@ -32,7 +32,7 @@ for user in $users; do
lecounter=0
for domain in $(search_objects 'web' 'LETSENCRYPT' 'yes' 'DOMAIN'); do
# Working on Web domain check - if is suspended
webSuspended=$(grep "DOMAIN='$domain'" $USER_DATA/web.conf |grep "SUSPENDED='no")
webSuspended=$(grep "DOMAIN='$domain'" $USER_DATA/web.conf |grep "SUSPENDED='yes")
if [ ! -z "$webSuspended" ]; then
continue;
fi;
Expand Down

1 comment on commit 58c6ca9

@tlcd96
Copy link
Contributor

@tlcd96 tlcd96 commented on 58c6ca9 Dec 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't saw that bro, sorry

Please sign in to comment.