Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create v-update-host-certificate #1317

Merged
merged 1 commit into from
Nov 12, 2017
Merged

Conversation

robindirksen1
Copy link
Contributor

Add a file that's setting the hostname certificate for exim, dovecot & vesta-web so the email is always with a valid LE certificate.

Todo:

  • add to cronjobs (default every month) of adds to lets encrypt renewall/request when updating system hostname certificate

Add a file that's setting the hostname certificate for exim, dovecot & vesta-web so the email is always with a valid LE certificate.

# Todo:
- add to cronjobs (default every month) of adds to lets encrypt renewall/request when updating system hostname certificate
@robindirksen1
Copy link
Contributor Author

@madeITBelgium @dpeca what do you guys think of this PR?

@madeITBelgium
Copy link
Collaborator

It's a good start. Maybe you can add a checkbox in de server configuration page. Also some config parameter that you know that letsencrypt is enabled.

@dpeca
Copy link
Collaborator

dpeca commented Nov 7, 2017

My experience says that it's better (for Exim and Dovecot) to use fullchain file insted of certificate file.
I think fullchain file is file with .pem extension in .../conf/web/ folder (correct me if it's not fullchain file?)
(edited)

@robindirksen1
Copy link
Contributor Author

Looks like the .pem file is the fullchain (that file contains the certificate of letsencrypt right?)?

@dpeca
Copy link
Collaborator

dpeca commented Nov 7, 2017

Yes, yes.
My bad.

pem = crt + ca

So, .pem file should be used instead of .crt

@dpeca
Copy link
Collaborator

dpeca commented Nov 7, 2017

I simply had certificate issue if I use just .crt file.
(Outlook says certificate is not trustable, etc...)

@robindirksen1
Copy link
Contributor Author

Apple mail to @dpeca

@dpeca
Copy link
Collaborator

dpeca commented Nov 7, 2017

The same stuff is with some browsers.
With fullchain everything works fine.

@robindirksen1
Copy link
Contributor Author

Nice, so okay, with this script the vestacp certificate is getting updated, if the users provide an alias with the request (for example: mail.server.com) it will be available in the mail to use mail.server.com (or the other aliases), right?

@dpeca
Copy link
Collaborator

dpeca commented Nov 8, 2017

I think yes.

@dpeca dpeca merged commit 9decddd into outroll:master Nov 12, 2017
@robindirksen1
Copy link
Contributor Author

so you think this is ready @dpeca ?

@dpeca
Copy link
Collaborator

dpeca commented Nov 12, 2017

I made few fixes - 38b7557

Todo: Script need to be called when vesta updates hostname SSL

@robindirksen1
Copy link
Contributor Author

Okay, nice! But when vesta updates hostname SSL, but when you set another user (not admin) domain to be the valid ssl, then it needs to use that certificate instead of the (default) hostname. Right?

@dpeca
Copy link
Collaborator

dpeca commented Nov 12, 2017

Well, when Vesta renew SSL's, it should check if it is server hostname, then Vesta will know when to call v-update-host-certificate and what is the owner of that domain.

I made another little fix - fc60a99

@robindirksen1
Copy link
Contributor Author

That's true, can it check the certificate which is used? Or maybe it's smarter to set a symbolic link to the correct folder, but can that with the permissions?

@dpeca
Copy link
Collaborator

dpeca commented Nov 13, 2017

Not sure about permisions, but current solution with copying is fine.
In next few days I'll take a look in what script we should trigger v-update-host-certificate (when Vesta set SSL for domin that is also hostname)

@dpeca
Copy link
Collaborator

dpeca commented Nov 15, 2017

Additional fix - ba14a64

@dpeca
Copy link
Collaborator

dpeca commented Apr 6, 2018

I made now option to automatically use this script - b2e75d8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants