Load commands dynamically #237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also allows a user to have their own commands in ~/.local/share/oo_bin/shims
QuantumGeordie
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
i'm not familiar with this code at all. but it looks to me like you are replacing the specific command loads with code that will load any commands in the commands directory as well as in a custom path outside of this repo. that seems clever and a good idea; just have to trust you on the implementation.
i see that there are tests in the repo, but don't know if this change exercises any of those. do you know?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also allows a user to have their own commands in ~/.local/share/oo_bin/shims