Adding support for terraform provider registry #50
Conversation
lib/server.js
Outdated
| @@ -1,4 +1,4 @@ | |||
| const http = require('http'); | |||
| const https = require('https'); | |||
There was a problem hiding this comment.
Yeah, will probably remove it but terraform provider registry requires HTTPS - once I've sorted the tests out, I should be able to remove https and https-localhost
There was a problem hiding this comment.
I have now removed https-localhost dependency as I added tests that utilise ngrok
sponte
changed the title
sponte
changed the title
|
Ok @ad-m - this is ready to review now - please have a look and let me know if you need me to make any changes before merging. |
|
Not sure who will be reviewing this @outsideris - I referenced @ad-m earlier as he commented on the commit before but since you approved my other PRs (HCLv2/Terraform v12 and small update to the docs), I thought I'd bring this one to your attention. Please let me know your thoughts. |
|
For clarity, I have no relationship with @outsideris . I am part of the community of this project because I follow it. I never even ddownloaded and started it. |
|
Sorry for late response. |
| .env | ||
| test/integration/fixture/provider | ||
| coverage/ | ||
| .nyc_output/ |
| @@ -19,11 +19,12 @@ const normalizePort = (val) => { | |||
| return false; | |||
| }; | |||
|
|
|||
| const run = () => { | |||
| const run = async () => { | |||
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "citizen", | |||
| "version": "0.3.3", | |||
| "version": "1.0.0", | |||
There was a problem hiding this comment.
I don't want to version up now.
There was a problem hiding this comment.
The reason version went up is that this MR introduces breaking changes in citizen cli
| // error.status = 409; | ||
| // error.message = `${destPath} is already exist.`; | ||
| // return next(error); | ||
| // } |
|
I rebased this PR on my local, see d698abf |
Thanks for creating citizen - a missing registry for Terraform Modules. I have a need to host custom providers and thought of extending your project.
This PR adds support for hosting custom providers utilising Hashicorp's provider registry protocol documented at https://www.terraform.io/docs/internals/provider-registry-protocol.html.
Changes
citizencli commands for publishing providers and trusted publishersI have updated the version to
1.0.0to indicate breaking changes:citizen publishcommand is no longer top level command ascitizencan now publish modules, providers and publishersmodulesandprovidersdirectories. This means new version won't work with existing registries, although careful migration is possible