Link source maps to raw.githubusercontent.com #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! But I think it should be: - val a = baseDirectory.value.toURI.toString.replaceFirst("[^/]+/?$", "")
+ val a = baseDirectory.value.toURI |
fdietze
force-pushed
the
fix-source-maps
branch
from
5546b14
to
b71c88a
Compare
|
I cannot find any relevant url in the source-map files. I think this is for source-maps from scalaJS itself, but bundler does not adopt it yet. |
|
The urls are in the |
mariusmuja
approved these changes
Dec 2, 2017
fdietze
force-pushed
the
fix-source-maps
branch
2 times, most recently
from
f3d4927
to
a7294b9
Compare
fdietze
force-pushed
the
fix-source-maps
branch
from
a7294b9
to
3f5cd8e
Compare
|
I now included the current git hash in the URL, which should always load the correct source file. Try it with this dependency: "com.github.fdietze" % "outwatch" % "3f5cd8e"I suggest that other libraries use this approach as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw this interesting snippet in build.sbt and thought , that it might be useful for debugging. But I wasn't able to verify that its working.