Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HandlerFactories should be functions #102

Merged
merged 1 commit into from Nov 25, 2017
Merged

HandlerFactories should be functions #102

merged 1 commit into from Nov 25, 2017

Conversation

cornerman
Copy link
Member

No description provided.

@LukaJCB
Copy link
Member

LukaJCB commented Nov 25, 2017

What's wrong with the current encoding?

@cornerman
Copy link
Member Author

Why should the handler factory methods be lazy vals? Both should work, as the implicit class is instantiated every time I call one of the properties (Handler.inputEvents, Handler.mouseEvents, ...). So the vals would not persist, but there is also no advantage over using def, which is cheaper.

@LukaJCB
Copy link
Member

LukaJCB commented Nov 25, 2017

Aaah yes that makes perfect sense! +1

fdietze
fdietze approved these changes Nov 25, 2017
View reviewed changes
Copy link
Member

@fdietze fdietze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change!

@fdietze fdietze merged commit 64a6cb3 into master Nov 25, 2017
@fdietze fdietze deleted the handlerfactories-fun branch November 25, 2017 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdietze fdietze fdietze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cornerman @LukaJCB @fdietze