Hooks optimisations and refactorings #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cornerman
reviewed
Dec 6, 2017
| final case class DestroyHook(observer: Observer[Element]) extends Hook | ||
| final case class UpdateHook(observer: Observer[(Element, Element)]) extends Hook | ||
|
|
||
| sealed trait HookSingle extends Hook { |
There was a problem hiding this comment.
Can we make these traits generic? So we have def observer: Observer[T]. We can later pattern match on the value when mapping.
There was a problem hiding this comment.
If there is a way to make this trait generic and combine the functions createHookSingle etc. , great. But if that turns out to be impractical, I'm fine with this solution.
fdietze
approved these changes
Dec 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, even if there are no hook sinks present on a
VNode, there are empty insert/update/create hooks created for all theVNodes. This PR leaves the hooks asundefinedin case there are no hook sinks present.The PR also adds support for the
prepatch/postpatchhooks. I neededpostpatchfor frameworks such Material Design Lite and Materialize that require dynamic components to be "upgraded" after they are inserted in the DOM (using theupdatehooks did not work, the "upgrading" has to happen after the snabbdom patch is completed).