Modifier separation refactorings #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation of Snabdom structures in one place. Removed outwatch dependencies from the snabbdom package
cornerman
approved these changes
Dec 11, 2017
|
Very nice work on the separation! |
mariusmuja
added a commit
to mariusmuja/outwatch
that referenced
this pull request
Dec 11, 2017
|
Are we ready to merge this? |
mariusmuja
added a commit
to mariusmuja/outwatch
that referenced
this pull request
Dec 12, 2017
fdietze
approved these changes
Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #120, I did some more refactoring to the modifier separation, so that there's a single fold over all the
VDomModifier_elements in aVTree. I've tried to keep the hierarchy created during the modifier separation mirror closely theVDomModifier_hierarchy, so that the code is easy to follow.Also, I've moved the logic that creates the Snabbdom data structures to a different file (Snabbdom.scala) and removed
outwatchdependencies from thesnabbdompackage, makes fixing #73 easy.Moved
DomUtils.rendertoOutWatchobject, fixes #70, fixes #74.