Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename on{Pre,Post}patch to on{Pre,Post}Patch #150

Merged
merged 1 commit into from Jan 12, 2018
Merged

Rename on{Pre,Post}patch to on{Pre,Post}Patch #150

merged 1 commit into from Jan 12, 2018

Conversation

fdietze
Copy link
Member

@fdietze fdietze commented Jan 12, 2018 •
edited

This makes it more consistent with all the other camel-case identifiers.

cornerman
cornerman approved these changes Jan 12, 2018
View reviewed changes
Copy link
Member

@cornerman cornerman left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, somehow PostPatch looks more correct (sic!) to my eye :)

@fdietze fdietze merged commit 11f32a0 into master Jan 12, 2018
@fdietze fdietze deleted the postpatch-camelcase branch January 12, 2018 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusmuja mariusmuja mariusmuja approved these changes

@cornerman cornerman cornerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fdietze @mariusmuja @cornerman