Refactor implicit conversions to VDomModifier #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdietze
reviewed
Jan 17, 2018
| node.innerHTML shouldBe "1" | ||
|
|
||
| OutWatch.renderReplace(node, div(1.0)).unsafeRunSync() | ||
| node.innerHTML shouldBe "1" |
There was a problem hiding this comment.
Why is a Double 1.0 rendered as 1 and not 1.0?
There was a problem hiding this comment.
Apparently that's how Scala.js renders Double.toString:
There was a problem hiding this comment.
Ok! I just tried in the scala REPL and it was "1.0".
There was a problem hiding this comment.
Scala REPL is JVM.
fdietze
approved these changes
Jan 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More consistent handling of implicit conversions to
VDomModifierthough theAsVDomModifiertype class. This removes all (except one) implicit conversions toVDomModifierfrom thedompackage object.It also allows to have
Seq[String],Seq[Int](anySeq[T : AsVomModifier]) in the VDom (see #155).