hot fix not accumulating class attribute if streamed #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdietze
approved these changes
Jul 24, 2018
LukaJCB
approved these changes
Jul 24, 2018
cornerman
force-pushed
the
stream-accum-attr
branch
from
72d3820
to
0d7bff0
Compare
cornerman
added a commit
that referenced
this pull request
Mar 18, 2019
cornerman
added a commit
to cornerman/outwatch
that referenced
this pull request
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem when we stream
AccumAttrsorAccumStylesand update the data object of a vnode proxy.For example:
div( cls := "first", cls <-- myClasses )Here, the second
clsattribute stream overwrites the staticcls := "first". But it should actually accumulate both classes, as it would do for two static class attributes. The same problem exists for styles.This PR is just a hot fix for
class, as it is the only default AccumAttribute we have. But this should be fixed properly in a another PR.