tests: remove unsafeRunSync usage #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahjohannessen
force-pushed
the
wip-remove-unsafe-run-sync-usage
branch
from
202c7de
to
fb7fc92
Compare
ahjohannessen
force-pushed
the
wip-remove-unsafe-run-sync-usage
branch
4 times, most recently
from
ffca6dd
to
54d4431
Compare
ahjohannessen
force-pushed
the
wip-remove-unsafe-run-sync-usage
branch
from
54d4431
to
115d9bb
Compare
LukaJCB
approved these changes
Sep 17, 2018
fdietze
reviewed
Sep 17, 2018
| trait EasySubscribe { | ||
|
|
||
| implicit class Subscriber[T](obs: Observable[T]) { | ||
| def apply(next: T => Unit)(implicit s: Scheduler): Cancelable = obs.subscribe { t => | ||
| def apply(next: T ⇒ Unit)(implicit s: Scheduler): Cancelable = obs.subscribe { t ⇒ |
There was a problem hiding this comment.
I'd prefer to stay with ascii arrows instead of unicode ones.
There was a problem hiding this comment.
I'll update it to use ascii
There was a problem hiding this comment.
@fdietze updated PR to use <- instead of ← and => instead of ⇒ in tests
- add `AsyncFlatSpec` from scalatest and introduce two variants of `JSDomSpec`. - refactor tests that rely on `unsafeRunSync` to use `unsafeToFuture` from scalatest. Furthermore, there is an implicit conversion from `IO[Assertion]` to `Future[Assertion]` in `JSDomAsyncSpec` that reduces usage of `unsafeToFuture` boilerplate.
ahjohannessen
force-pushed
the
wip-remove-unsafe-run-sync-usage
branch
from
115d9bb
to
75bffde
Compare
fdietze
approved these changes
Sep 18, 2018
|
LGTM! Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
AsyncFlatSpecfrom scalatest and introducetwo variants of
JSDomSpec.refactor tests that rely on
unsafeRunSynctouse
unsafeToFuturefrom scalatest. Furthermore,there is an implicit conversion from
IO[Assertion]to
Future[Assertion]inJSDomAsyncSpecthat reducesusage of
unsafeToFutureboilerplate.