fix wrong order of mount and unmount when streamed #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cornerman
force-pushed
the
order-mount-unmount
branch
from
d3e11bf
to
7057f9d
Compare
|
I have updated this PR. It works as expected now :) |
fdietze
approved these changes
Dec 17, 2018
cornerman
force-pushed
the
order-mount-unmount
branch
from
7057f9d
to
662002f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic of streamed unmount hooks has a flaw. It uses
PostPatchHookswhich are not guaranteed to be run before all mount hooks of the next patch-iteration. This PR now usesUpdateHookfor mirroring streamed unmount hooks. This will always be done before any mount hook which is called from an insert or post patch hook. And importantly it also needs to be done after thePrePatchHooksbecause of thunks and because prepatch can be called more often than update by snabbdom.Based on #273