Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use snabbdom/tovnode for renderReplace #280

Merged
merged 1 commit into from Jan 10, 2019
Merged

Use snabbdom/tovnode for renderReplace #280

merged 1 commit into from Jan 10, 2019

Conversation

fdietze
Copy link
Member

@fdietze fdietze commented Jan 9, 2019

This is replacing the custom approach with the correct one. Before, renderReplace kept the attributes of the tag. Now the whole tag will be replaced correctly.

cornerman
cornerman approved these changes Jan 9, 2019
View reviewed changes
Copy link
Member

@cornerman cornerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this should fix problems with using renderReplace multiple times and is the correct way of patching an existing element. Thank you!

@fdietze fdietze merged commit b2dddb7 into master Jan 10, 2019
@fdietze fdietze deleted the fixrenderreplace branch January 10, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cornerman cornerman cornerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fdietze @cornerman