Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor remove sink deprecation #325

Merged
merged 4 commits into from Aug 5, 2019
Merged

Refactor remove sink deprecation #325

merged 4 commits into from Aug 5, 2019

Conversation

zakpatterson
Copy link
Contributor

Removes deprecated Sink and a few associated things, which were deprecated several months ago.

There are other deprecations which are not used that could be deleted. For now I'm just addressing Sink and Pipe.

@zakpatterson
Remove Sink, and deprecations
0b8f4a5 
Removed several deprecated functions and type aliases, that were
deprecated 8 months ago and not used much in the code base.
@zakpatterson
Rename sink variable names to observer
4dce6d7
fdietze
fdietze approved these changes Aug 5, 2019
View reviewed changes
Copy link
Member

@fdietze fdietze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
This looks good to me. It was about time to remove the deprecations and move on.

@fdietze fdietze requested a review from cornerman August 5, 2019 17:55
@zakpatterson
Copy link
Contributor Author

@cornerman updated branch, ready for you when you can take a look.

@cornerman
Copy link
Member

cornerman commented Aug 5, 2019 •
edited

Great idea! In general I am fine with removing deprecated stuff. But we have never deprecated the Sink object, because we needed these methods and never came up with a better name. I think, ObserverBuilder is a good name and might even be more intuitive than Sink. Though, we should keep @deprecated val Sink = ObserverBuilder, so the code still compiles for our users. In a later stage, we can then remove this entirely. So can you please add a redirect for Sink?

Otherwise, this looks good to me!

cornerman
cornerman approved these changes Aug 5, 2019
View reviewed changes
Copy link
Member

@cornerman cornerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cornerman cornerman merged commit 3515a92 into outwatch:master Aug 5, 2019
@zakpatterson zakpatterson deleted the refactor-remove-sink-deprecation branch August 7, 2019 00:36
cornerman pushed a commit to cornerman/outwatch that referenced this pull request Sep 24, 2021
@zakpatterson @cornerman
Refactor remove sink deprecation (outwatch#325)
f12ce2b 
* Remove Sink, and deprecations

Removed several deprecated functions and type aliases, that were
deprecated 8 months ago and not used much in the code base.

* Rename sink variable names to observer

* Add deprecation redirect Sink -> ObserverBuilder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cornerman cornerman cornerman approved these changes

@fdietze fdietze fdietze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zakpatterson @cornerman @fdietze