New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fix mdoc supersede 277 #339
Add fix mdoc supersede 277 #339
Conversation
Wow! Thank you for working on this one. 👍 |
It's by no means complete, I didn't try to scrape and fix the old website code, but i think it's an improvement over the giant readme, and hopefully we can improve the docs incrementally now that it's easier to do so. |
I commited some improvements. Unfortunately I'm not able to run docusaurus on NixOS. (It always tries to compile gifsicle, which I have already installed...) By removing many |
Ah yes I ran into that exact error actually, and that's why I just put |
@fdietze should we put the shareds back or what do you think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fdietze should we put the shareds back or what do you think
I think :shared
should only used as it was intended. For shared code, such as imports. With the new mdoc release it works without shared.
outwatch/yarn.lock
Outdated
@@ -1,3930 +0,0 @@ | |||
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why deleting yarn.lock? Probably a mistake...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have the need for yarn.lock in the same way js projects do. We don't care about reproducible resolutions of dependencies from npm. I get that's an opinion, but if we leave it then the entire file will change and innocent PRs could create 1000 line diffs, I just don't see the point of having it in this project.
What is the state here? :) |
I finally took the time to finish and merge. Also thanks to @zakpatterson ! |
This includes prior commits from 227, and more or less finishes the work of migrating the readme to mdoc with a docusarus site.
To run, this should work: