Update to Scala.js 1.8.0 #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thank you! |
|
Strange... After merging, CI is failing on master now, any ideas how to fix it? https://github.com/outwatch/outwatch/runs/4747821013?check_suite_focus=true
|
|
Actually, I thought it was strange that your project didn't have that problem, since mine did 😅 That is problem (3) from this issue that I wrote up: It's all very broken and confusing, sorry about that. I think I know how to fix, let me give it a try. |
Merged
cornerman
pushed a commit
to cornerman/outwatch
that referenced
this pull request
Feb 28, 2023
* Update sbt-scalajs, scalajs-compiler, ... to 1.8.0 * Add sjs linker dep to docs * Also add sjs compiler * Use full cross version for sjs compiler Co-authored-by: Scala Steward <me@scala-steward.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #551. This should hopefully get you unblocked while we wait for scalameta/mdoc#597.