Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove js.undefined render instances to not render Unit #738

Merged
merged 2 commits into from Sep 25, 2023
Merged

remove js.undefined render instances to not render Unit #738

merged 2 commits into from Sep 25, 2023

Conversation

cornerman
Copy link
Member

@cornerman cornerman commented Sep 25, 2023 •
edited

I am not sure why, but otherwise this implicit instance allows us to render a (), which we do not want. So, currently, you always have to convert a js.UndefOr with toOption to render it.

@cornerman cornerman enabled auto-merge (rebase) September 25, 2023 11:37
@cornerman cornerman merged commit f31d1d6 into master Sep 25, 2023
4 checks passed
@cornerman cornerman deleted the remove-undefined-render branch September 25, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdietze fdietze Awaiting requested review from fdietze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cornerman