The package will no longer return an array. A Json object will be ret…

…urned Api Calls response
ovac · Mar 24, 2018 · 544b933 · 544b933
1 parent 7bd724a
commit 544b933
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 4 deletions.
diff --git a/src/Api/Api.php b/src/Api/Api.php
@@ -154,7 +154,7 @@ public function execute($httpMethod, $url, array $parameters = [])
                     'json' => $parameters,
                 ]);
 
-                return json_decode((string) $this->response->getBody(), true);
+                return json_decode((string) $this->response->getBody());
 
             } catch (ClientException $e) {
                 throw new Handler($e);

diff --git a/tests/Unit/Api/Transaction/ReceiveMoneyTest.php b/tests/Unit/Api/Transaction/ReceiveMoneyTest.php
@@ -412,7 +412,7 @@ public function test_receive_money_end_2_end_successful()
 
         $result = $mock->run();
 
-        $this->assertEquals($result, ['X-Foo' => 'Bar']);
+        $this->assertEquals($result, json_decode(json_encode(['X-Foo' => 'Bar'])));
 
         $request = $container[0]['request'];
 

diff --git a/tests/Unit/Api/Transaction/RefundTest.php b/tests/Unit/Api/Transaction/RefundTest.php
@@ -175,7 +175,7 @@ public function test_send_money_end_2_end_successful()
 
         $result = $mock->run();
 
-        $this->assertEquals($result, ['X-Foo' => 'Bar']);
+        $this->assertEquals($result, json_decode(json_encode(['X-Foo' => 'Bar'])));
 
         $request = $container[0]['request'];
 

diff --git a/tests/Unit/Api/Transaction/SendMoneyTest.php b/tests/Unit/Api/Transaction/SendMoneyTest.php
@@ -377,7 +377,7 @@ public function test_send_money_end_2_end_successful()
 
         $result = $mock->run();
 
-        $this->assertEquals($result, ['X-Foo' => 'Bar']);
+        $this->assertEquals($result, json_decode(json_encode(['X-Foo' => 'Bar'])));
 
         $request = $container[0]['request'];
 

diff --git a/tests/Unit/Exception/HandlerTest.php b/tests/Unit/Exception/HandlerTest.php
@@ -161,6 +161,8 @@ public function test_4010_missenParameter_request_response()
             $this->assertContains('MissingParameter', $e->getErrorType());
             $this->assertContains('Some Field', $e->getMissingParameter());
             $this->assertContains('Other Field', $e->getMissingParameter());
+            $this->assertContains('Other Field', $e->getMessage());
+            $this->assertContains('Some Field', $e->getMessage());
 
             throw $e;
         }