Skip to content

Commit

Permalink
mark filesink with mkfifo as todo. see #8166
Browse files Browse the repository at this point in the history
  • Loading branch information
paperdave committed Mar 14, 2024
1 parent a7b65ad commit 3ce3538
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion test/js/bun/util/filesink.test.ts
@@ -1,6 +1,7 @@
// @known-failing-on-windows: 1 failing
import { ArrayBufferSink } from "bun";
import { describe, expect, it } from "bun:test";
import { isWindows } from "harness";
import { mkfifo } from "mkfifo";
import { tmpdir } from "node:os";
import { join } from "node:path";
Expand Down Expand Up @@ -77,7 +78,9 @@ describe("FileSink", () => {
}

for (let isPipe of [true, false] as const) {
describe(isPipe ? "pipe" : "file", () => {
// TODO: fix the `mkfifo` function for windows. They do have an API but calling it from bun:ffi didn't get great results.
// once #8166 is merged, this can be written using it's 'bun:iternals-for-testing' feature
describe.skipIf(isPipe && isWindows)(isPipe ? "pipe" : "file", () => {
fixtures.forEach(([input, expected, label]) => {
const getPathOrFd = () => (isPipe ? getFd(label, expected.byteLength) : getPath(label));

Expand Down

0 comments on commit 3ce3538

Please sign in to comment.