Skip to content

Commit

Permalink
fix(bun-test): test title in results (#1753)
Browse files Browse the repository at this point in the history
* fix(bun-test): test title in results

* missed case

* clean up import

* respond to reviews
  • Loading branch information
ethanburrell committed Jan 12, 2023
1 parent bb5efb6 commit 76e6a17
Show file tree
Hide file tree
Showing 3 changed files with 45 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/bun.js/test/jest.zig
Expand Up @@ -1737,7 +1737,7 @@ pub const DescribeScope = struct {
var scope = allocator.create(DescribeScope) catch unreachable;
scope.* = .{
.label = (label.toSlice(allocator).cloneIfNeeded(allocator) catch unreachable).slice(),
.parent = this,
.parent = active orelse this,
.file_id = this.file_id,
};
var new_this = DescribeScope.Class.make(ctx, scope);
Expand Down
8 changes: 6 additions & 2 deletions src/cli/test_command.zig
Expand Up @@ -113,7 +113,9 @@ pub const CommandLineReporter = struct {
const color_code = comptime if (skip) "<yellow>" else "";

if (Output.enable_ansi_colors_stderr) {
for (scopes) |scope| {
for (scopes) |_, i| {
const index = (scopes.len - 1) - i;
const scope = scopes[index];
if (scope.label.len == 0) continue;
writer.writeAll(" ") catch unreachable;

Expand All @@ -123,7 +125,9 @@ pub const CommandLineReporter = struct {
writer.writeAll(" >") catch unreachable;
}
} else {
for (scopes) |scope| {
for (scopes) |_, i| {
const index = (scopes.len - 1) - i;
const scope = scopes[index];
if (scope.label.len == 0) continue;
writer.writeAll(" ") catch unreachable;
writer.writeAll(scope.label) catch unreachable;
Expand Down
38 changes: 38 additions & 0 deletions test/bun.js/bun-test/nested-describes.test.ts
@@ -0,0 +1,38 @@
import {
describe,
expect,
test,
} from "bun:test";

/*
In this test we want the tests to print out the following on a success.
Each success / fail should show the path of describe and test scopes
✓ outer most describe > mid describe 1 > inner most describe 1 > first
✓ outer most describe > mid describe 1 > inner most describe 2 > second
✓ outer most describe > mid describe 2 > inner most describe 3 > first
@TODO add testing for this, would require to read the test console output
*/

describe("outer most describe", () => {
describe("mid describe 1", () => {
describe("inner most describe 1", () => {
test("first", () => {
expect(5).toEqual(5);
})
})
describe("inner most describe 2", () => {
test("second", () => {
expect(5).toEqual(5);
})
})
})
describe("mid describe 2", () => {
describe("inner most describe 3", () => {
test("third", () => {
expect(5).toEqual(5);
})
})
})
})

0 comments on commit 76e6a17

Please sign in to comment.