Bun.serve throw Error log on async

[SaltyAom]

What version of Bun is running?

0.2.2

What platform is your computer?

Darwin 22.1.0 Darwin Kernel Version 22.1.0: Sun Oct 9 20:15:09 PDT 2022; root:xnu-8792.41.9~2/RELEASE_ARM64_T6000 arm64 arm

What steps can reproduce the bug?

According to the doc, in the fetch function we can throw new Error("") then handle the error in error() method.

Bun.serve({
	port: 3000,
	fetch() {
		throw new Error('A')

		return new Response('A')
	},
	error() {
		return new Response('Handled')
	}
})

This works as expected, it produces no error log because it's handled via error().

But when fetch is async, the request is finished but then there would be an error log.

Bun.serve({
	port: 3000,
	fetch: async () => {
		throw new Error('A')

		return new Response('A')
	},
	error() {
		return new Response('Handled')
	}
})

This would have a problem with:

1. Testing for custom error handling logic in a test environment using bun wiptest, the test will fail.
2. Redundant logging for production usage.

How often does it reproduce? Is there a required condition?

This always happens when using fetch as async

What is the expected behavior?

Throwing error in Bun.serve should have the same behavior in both sync and async, and the test suite should not fail when an error is thrown when using async with error handler.

What do you see instead?

An error log.

Additional information

No response

[Electroid]

@robobun

const server = Bun.serve({
  async fetch() {
    throw new Error("Oops!");
    return new Response("Unreachable");
  },
  error() {
    return new Response("Works!");
  }
});
const response = await server.fetch(new Request("http://localhost:3000/hello"));
console.log(await response.text());
server.stop();

[robobun]

Here is the output of the code that was provided.

Code

const server = Bun.serve({
async fetch() {
throw new Error("Oops!");
return new Response("Unreachable");
},
error() {
return new Response("Works!");
}
});
const response = await server.fetch(new Request("http://localhost:3000/hello"));
console.log(await response.text());
server.stop();

1 | const server = Bun.serve({
2 | async fetch() {
3 | throw new Error("Oops!");
^
error: Oops!
at /tmp/bun-Mhl3Qw/15d9d3cc7dc3473f1da1f4401d79d210214e5d21a8426c25fd42a555ae544984.ts:3:10
at fetch (/tmp/bun-Mhl3Qw/15d9d3cc7dc3473f1da1f4401d79d210214e5d21a8426c25fd42a555ae544984.ts:2:16)
at /tmp/bun-Mhl3Qw/15d9d3cc7dc3473f1da1f4401d79d210214e5d21a8426c25fd42a555ae544984.ts:10:23

Code was run using the latest build of Bun.

[Jarred-Sumner]

we should check if this still happens

[SaltyAom]

Thanks~ Doesn't happen on my end using Bun 0.5.7.

[alexdatsyuk]

Hey there! This issue is still reproducible on the 1.0 release. Please keep an eye on it. Thanks!

[danielstaleiny]

bump, I can also reproduce the issue in 1.0.1 and 1.0.2 version of the bun.

[TiBianMod]

still reproducible on 1.0.8

any luck on this?