Support `discord.js` #2077

ThatOneBro · 2023-02-15T07:25:32Z

We've long had requests for discord.js support. It doesn't seem too far away now that we've got undici.Agent and a workaround for the worker_threads requirement.

Currently it looks like we need the following to finish support for discord.js:

undici.request (tracking in Implement some undici APIs #1987)
response.arrayBuffer() hangs when called more than once (no tracking yet)

The text was updated successfully, but these errors were encountered:

net-tech · 2023-03-16T17:02:05Z

Is there any update on

response.arrayBuffer() hangs when called more than once (no tracking yet)

ThatOneBro · 2023-03-18T07:50:53Z

@net-tech I think a fix may have just made it into main, I'll check tomorrow and update this issue accordingly

ThatOneBro · 2023-03-20T18:44:03Z

Update: response.arrayBuffer() no longer hangs, but when calling the function Bun reports undefined is not a function although when console.log()ing response.arrayBuffer just before calling it, it seems to be defined as the appropriate function. Will take a closer look at this soon.

Mw3y · 2023-03-20T19:20:06Z

I got the same error with the Winston logging library. It looks like it's a general issue.

net-tech · 2023-03-25T15:58:31Z

Update: response.arrayBuffer() no longer hangs, but when calling the function Bun reports undefined is not a function although when console.log()ing response.arrayBuffer just before calling it, it seems to be defined as the appropriate function. Will take a closer look at this soon.

Hey any update on that closer look? Not trying to be a bother, just wondering if there's been any progress.

trnxdev · 2023-04-02T15:06:29Z

I just want to say I am experiencing the same issue

bun version: 0.5.8
discord.js version: 14.9.0

68 |   }
69 | 
70 |   async arrayBuffer() {
71 |     this.#consume();
72 | 
73 |     return await this.#response.arrayBuffer();
                    ^
TypeError: undefined is not a function
      at undici:73:17
      at arrayBuffer (undici:71:22)
      at parseResponse (/mnt/c/Users/tiramify/Documents/bunsh/node_modules/.pnpm/@discordjs+rest@1.7.0/node_modules/@discordjs/rest/dist/index.js:493:29

ThatOneBro · 2023-04-02T17:30:53Z

Gonna check on this one later today. There was an issue in our fetch implementation that was causing this but I think it might have been merged into canary already.

GillHoang · 2023-04-05T11:38:03Z

Gonna check on this one later today. There was an issue in our fetch implementation that was causing this but I think it might have been merged into canary already.

i can't use bun for discord.js when update to latest bun build

trnxdev · 2023-04-05T12:03:15Z

i can't use bun for discord.js when update to latest bun build

Same: (token is there, it's just invisible cuz of my blur)

GillHoang · 2023-04-05T12:38:11Z

i can't use bun for discord.js when update to latest bun build

Same: (token is there, it's just invisible cuz of my blur)

just wait util have new update, .-. i very want to use bun intead of tsc and run

redraskal · 2023-05-01T04:45:03Z

I just want to say I am experiencing the same issue

bun version: 0.5.8 discord.js version: 14.9.0

68 |   }
69 | 
70 |   async arrayBuffer() {
71 |     this.#consume();
72 | 
73 |     return await this.#response.arrayBuffer();
                    ^
TypeError: undefined is not a function
      at undici:73:17
      at arrayBuffer (undici:71:22)
      at parseResponse (/mnt/c/Users/tiramify/Documents/bunsh/node_modules/.pnpm/@discordjs+rest@1.7.0/node_modules/@discordjs/rest/dist/index.js:493:29

res.headers['content-type'] returns undefined (I think you have to use res.headers.get("content-type") with Bun?), so res.body.json() is never called.

export async function parseResponse(res: Dispatcher.ResponseData): Promise<unknown> {
	const header = parseHeader(res.headers['content-type']);
	if (header?.startsWith('application/json')) {
		return res.body.json();
	}

	return res.body.arrayBuffer();
}

https://github.com/discordjs/discord.js/blob/f27631175a97b8a7620efedc24073fdb944cb728/packages/rest/src/lib/utils/utils.ts#L64

trnxdev · 2023-05-04T09:57:17Z

Now it managed to succeed, after I downloaded @discordjs/rest package and replace the source code in dist/index.js (res.headers.get('content-type') instead of res.headers['content-type']) it managed to go past client.login!

Now the next problem is

612 |     super();
613 |     this.strategy = strategy;
614 |     this.id = id;
615 |   }
616 |   async connect() {
617 |     const promise = this.initialConnectResolved ? Promise.resolve() : (0, import_node_events2.once)(this, "ready" /* Ready */);
                                                                     ^
TypeError: Not enough arguments
      at /home/tiramify/Documents/newbun/node_modules/.pnpm/@discordjs+ws@0.8.2/node_modules/@discordjs/ws/dist/index.js:617:66
      at connect (/home/tiramify/Documents/newbun/node_modules/.pnpm/@discordjs+ws@0.8.2/node_modules/@discordjs/ws/dist/index.js:616:18)
      at /home/tiramify/Documents/newbun/node_modules/.pnpm/@discordjs+ws@0.8.2/node_modules/@discordjs/ws/dist/index.js:1113:20
      at connect (/home/tiramify/Documents/newbun/node_modules/.pnpm/@discordjs+ws@0.8.2/node_modules/@discordjs/ws/dist/index.js:1110:18)
      at /home/tiramify/Documents/newbun/node_modules/.pnpm/@discordjs+ws@0.8.2/node_modules/@discordjs/ws/dist/index.js:1367:10

Also I just found more res.headers[''] instead of res.headers.get() in the discord.js rest file, after changing everything I also needed to change

   if (header === void 0 || typeof header === "string") {
    return header;
  }

to

    if (header == void 0 || typeof header === "string") {
    return header;
  }

because one of the headers returned is equal to null.

it still however returned Promise.resolve error

UPDATE: The error is not in Promise.resolve but rather in import_node_events2.once(this, "ready")

after a bit of trials I found out when you use

import_node_events2.once(this, "ready", {})

it works. But there are still a lot of errors.

trnxdev · 2023-05-26T21:32:55Z

After I and some guys on the discord server investigated the issue (we still are) we found out that these versions work:

14.9.0: works (normal bun)
14.8.0: works (normal bun)
13.16.0: works (normal bun)
13.14.0: works (normal bun)

Anything above 14.9.0 doesn't work, Anything below 14.0.0 requires modified

node_modules/discord.js:
src/rest/APIRequest.js,
src/util/DataResolver.js,
src/util/Util.js.

you need to remove the line const fetch = require('node-fetch') from every file i mentioned above.

For anything above 14.0.0 you should (example below made for 14.9.0)

node_modules/@discordjs/rest/dist/index.js:
change res.headers["(text)"] to res.headers.get("(text)") and maybe on line 453 === void 0 with just == void 0

I didn't fully test this, but the bot seems to launch.

trnxdev · 2023-05-26T21:34:07Z

(discord.js version on the picture,14.9.0)

paperdave · 2023-05-30T22:07:54Z

discord.js is working on this branch

didn't test every feature of it.

if you're curious why arrayBuffer() was breaking, we were trying to call .then on what we thought was a promise but it was actually just the value.

GillHoang · 2023-05-31T03:20:07Z

discord.js is working on this branch

didn't test every feature of it.

if you're curious why arrayBuffer() was breaking, we were trying to call .then on what we thought was a promise but it was actually just the value.

how you can do that

trnxdev · 2023-05-31T12:56:16Z

how you can do that

It's not out yet, just wait a couple days and upgrade your version of bun.

GillHoang · 2023-05-31T15:09:50Z

how you can do that

It's not out yet, just wait a couple days and upgrade your version of bun.
hmm after i edit something, it works, but when using class Client for extend, i got some error :((

trnxdev · 2023-05-31T15:58:58Z

how you can do that

It's not out yet, just wait a couple days and upgrade your version of bun.
hmm after i edit something, it works, but when using class Client for extend, i got some error :((

Do you have discord? It's more comfortable for me to help you there than on GitHub.
Here is a server link in case you do https://discord.gg/bun-876711213126520882

GillHoang · 2023-06-01T12:08:39Z

how you can do that

It's not out yet, just wait a couple days and upgrade your version of bun.
hmm after i edit something, it works, but when using class Client for extend, i got some error :((

Do you have discord? It's more comfortable for me to help you there than on GitHub. Here is a server link in case you do https://discord.gg/bun-876711213126520882

yep i am in bun server, my discord is GillCoder#7005

ImLunaHey · 2023-06-03T12:24:00Z

Still hitting issue with discord.js 😢

#1987
#2688 (comment)

Jarred-Sumner · 2023-06-03T12:26:10Z

That stack trace is interesting. It shouldn’t be going to undici through node_modules and it shouldn’t be going through undici for websockets either. Hm

…

On Sat, Jun 3, 2023 at 5:24 AM Luna ***@***.***> wrote: Still hitting issue with discord.js 😢 #1987 <#1987> #2688 (comment) <#2688 (comment)> — Reply to this email directly, view it on GitHub <#2077 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFNGS724KIPIH365C7QU6LXJMUGZANCNFSM6AAAAAAU4PNSFQ> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

ImLunaHey · 2023-06-03T12:33:03Z

@Jarred-Sumner happy to provide more details here or in the discord. Same username there.

ThatOneBro added ecosystem Something that relates to package or framework compatibility enhancement New feature or request labels Feb 15, 2023

ThatOneBro mentioned this issue Feb 23, 2023

feat(undici): add undici.request #2136

Merged

brianprost added a commit to brianprost/abrys-fam-bot that referenced this issue Apr 30, 2023

bun is kind of broken with discord.js: oven-sh/bun#2077

50f3560

paperdave mentioned this issue May 30, 2023

Fix streams breaking on reverted EventEmitter / Make Discord.js work #2913

Merged

Jarred-Sumner closed this as completed in #2913 Jun 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support `discord.js` #2077

Support `discord.js` #2077

ThatOneBro commented Feb 15, 2023 •

edited by paperdave

net-tech commented Mar 16, 2023

ThatOneBro commented Mar 18, 2023

ThatOneBro commented Mar 20, 2023

Mw3y commented Mar 20, 2023

net-tech commented Mar 25, 2023

trnxdev commented Apr 2, 2023 •

edited

ThatOneBro commented Apr 2, 2023

GillHoang commented Apr 5, 2023 •

edited

trnxdev commented Apr 5, 2023 •

edited

GillHoang commented Apr 5, 2023

redraskal commented May 1, 2023

trnxdev commented May 4, 2023 •

edited

trnxdev commented May 26, 2023 •

edited

trnxdev commented May 26, 2023 •

edited

paperdave commented May 30, 2023

GillHoang commented May 31, 2023

trnxdev commented May 31, 2023 •

edited

GillHoang commented May 31, 2023

trnxdev commented May 31, 2023

GillHoang commented Jun 1, 2023

ImLunaHey commented Jun 3, 2023

Jarred-Sumner commented Jun 3, 2023 via email

ImLunaHey commented Jun 3, 2023

Support discord.js #2077

Support discord.js #2077

Comments

ThatOneBro commented Feb 15, 2023 • edited by paperdave

net-tech commented Mar 16, 2023

ThatOneBro commented Mar 18, 2023

ThatOneBro commented Mar 20, 2023

Mw3y commented Mar 20, 2023

net-tech commented Mar 25, 2023

trnxdev commented Apr 2, 2023 • edited

ThatOneBro commented Apr 2, 2023

GillHoang commented Apr 5, 2023 • edited

trnxdev commented Apr 5, 2023 • edited

GillHoang commented Apr 5, 2023

redraskal commented May 1, 2023

trnxdev commented May 4, 2023 • edited

trnxdev commented May 26, 2023 • edited

trnxdev commented May 26, 2023 • edited

paperdave commented May 30, 2023

GillHoang commented May 31, 2023

trnxdev commented May 31, 2023 • edited

GillHoang commented May 31, 2023

trnxdev commented May 31, 2023

GillHoang commented Jun 1, 2023

ImLunaHey commented Jun 3, 2023

Jarred-Sumner commented Jun 3, 2023 via email

ImLunaHey commented Jun 3, 2023

Support `discord.js` #2077

Support `discord.js` #2077

ThatOneBro commented Feb 15, 2023 •

edited by paperdave

trnxdev commented Apr 2, 2023 •

edited

GillHoang commented Apr 5, 2023 •

edited

trnxdev commented Apr 5, 2023 •

edited

trnxdev commented May 4, 2023 •

edited

trnxdev commented May 26, 2023 •

edited

trnxdev commented May 26, 2023 •

edited

trnxdev commented May 31, 2023 •

edited