Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement node:cluster module #2428

Open
Tushar-Chavan14 opened this issue Mar 19, 2023 · 44 comments · May be fixed by #11492
Open

Implement node:cluster module #2428

Tushar-Chavan14 opened this issue Mar 19, 2023 · 44 comments · May be fixed by #11492
Assignees
Labels
bug Something isn't working node.js Compatibility with Node.js APIs

Comments

@Tushar-Chavan14
Copy link

What version of Bun is running?

0.5.7

What platform is your computer?

Linux 6.2.0-76060200-generic x86_64 x86_64

What steps can reproduce the bug?

bun i rate-limiter-flexible

import { RateLimiterMemory } from "rate-limiter-flexible";

const rateLimiter = new RateLimiterMemory({
points: 5,
duration: 120,
});

What is the expected behavior?

No response

What do you see instead?

No response

Additional information

No response

@Tushar-Chavan14 Tushar-Chavan14 added the bug Something isn't working label Mar 19, 2023
@Jarred-Sumner
Copy link
Collaborator

We haven't implemented the Node.js cluster module yet.

@Jarred-Sumner Jarred-Sumner changed the title error: Cannot find package "cluster" from "/home/tushar/projects/rateLimiter/node_modules/rate-limiter-flexible/lib/RateLimiterCluster.js" Implement node:cluster module Apr 1, 2023
@ThatOneCalculator
Copy link
Contributor

Is there currently any other way to do multiprocessing/multithreading with bun? This seems like it should be a very high priority item to support.

@xb1itz
Copy link

xb1itz commented Sep 10, 2023

+1 on this. The lack of node:cluster implementation is probably the main reason we are not switching to Bun right now.

@CharnSrinivas
Copy link

CharnSrinivas commented Sep 12, 2023

+1 on this. The lack of node:cluster implementation is probably the main reason we are not switching to Bun right now.
Same here i am shifting back to node since i get know that node:cluster is not available yet

@melroy89
Copy link

melroy89 commented Sep 16, 2023

I got indeed:

error: Could not resolve Node.js builtin: "cluster". To use Node.js builtins, set target to 'node' or 'bun'

const cluster = require('cluster')

I was very surprised to see this error. EDIT: I know cluster is not yet implemented. But then don't call it bun 1.0 yet.

@joshholly
Copy link

I ran bun --bun run dev to run my nextJS app. And I got this exact error.

@ThatOneCalculator
Copy link
Contributor

Well, node:cluster isn't implemented yet, so that's why you're seeing the error.

@ElYaiko
Copy link

ElYaiko commented Sep 25, 2023

+1

@masfahru
Copy link

masfahru commented Sep 29, 2023

For now (Bun v.1.0.3), I can imitate the behavior of the node:cluster in Bun to spawn as many server instances as the number of CPU cores, using this script.

spawn.ts

import os from "node:os";

const numCPUs = os.cpus().length;
for (let i = 0; i < numCPUs; i++) {
  Bun.spawn(["bun", "index.ts"], {
    stdio: ["inherit", "inherit", "inherit"],
    env: { ...process.env },
  });
}

index.ts

Bun.serve({
  port: 8080,
  reusePort: true, // allow Bun server instances to use same port 
  fetch(req: Request) {
    // ...

run bun spawn.ts

@calebeaires
Copy link

calebeaires commented Oct 6, 2023

@masfahru,

I performed the test and observed that the process ID remains the same every time I access the endpoint and print it. It appears that the access point is not redistributing properly.

 if (process.pid) {
            console.log(process.pid);
 }

index.ts

const server = Bun.serve({
    port: 3000,
    // @ts-ignore
    reusePort: true, // allow Bun server instances to use same port
    fetch(request) {
        if (process.pid) {
            console.log(process.pid);
        }
        return new Response("Welcome to Bun!");
    },
});

console.log(`Listening on localhost:${server.port}`);

cluster.ts

import os from "node:os";

const numCPUs = os.cpus().length;
for (let i = 0; i < numCPUs; i++) {
    Bun.spawn(["bun", "index.ts"], {
        stdio: ["inherit", "inherit", "inherit"],
        env: { ...process.env },
    });
}

@masfahru
Copy link

masfahru commented Oct 6, 2023

@calebeaires

SO_REUSEPORT is a builtin way to do load balancing, but it only really works properly on Linux.

Sorry, I don't know how load balancing works in Bun. To fulfill my curiosity about Bun server performance, I have tested the script in the TechEmpower Framework Benchmark, and the result is amazing. Bun is able to serve up to 2.7M requests per second for plain text test.

image
https://www.techempower.com/benchmarks/#section=test&runid=235acf72-7de8-4f61-baca-36c2df35a5c0&test=plaintext&l=zik0zj-33z

@calebeaires
Copy link

@masfahru, you're right. I've tested in a linux machine and works like a charm.

@ThatOneCalculator
Copy link
Contributor

@calebeaires Would you mind sharing the details on what hardware/setup was used to achieve those numbers?

@calebeaires
Copy link

On M1 Mac OS 8 cores, it does not work. On linux, Ubuntu 22, 2 cores I could get a good result. Sending concurrent requests to Bun server that console log the process.id numbers, we get different results.

@Electroid Electroid added the node.js Compatibility with Node.js APIs label Oct 25, 2023
@ednt
Copy link

ednt commented Nov 1, 2023

+1 on this. The lack of node:cluster implementation is probably the main reason we are not switching to Bun right now.

THIS!

@CsVeryLoveXieWenLi

This comment was marked as duplicate.

@Matthew-Tersigni
Copy link

+1 I Can't fully convert my node apps to bun without this feature.

@arbile26

This comment was marked as duplicate.

@ThatOneCalculator
Copy link
Contributor

Can we please keep this thread productive, such as discussing potential implementations?

@ndaidong
Copy link

I'm looking forward to seeing this feature implemented in Bun.

@ganeshkbhat
Copy link

ganeshkbhat commented Nov 28, 2023

+1 for this.

I am also recommend implementing cluster_thread module which is genuinely a good starting point for creating clusters of threads like clusters of processes in node.js. Currently a multi-threading option is a little buggy. There is no random round robin as well in Windows due to absence of file descriptor module [presumed - check] in windows environment.

This is the Node.js Suggestion recommendation. nodejs/node#48350

@masfahru,

I performed the test and observed that the process ID remains the same every time I access the endpoint and print it. It appears that the access point is not redistributing properly.

 if (process.pid) {
            console.log(process.pid);
 }

index.ts

const server = Bun.serve({
    port: 3000,
    // @ts-ignore
    reusePort: true, // allow Bun server instances to use same port
    fetch(request) {
        if (process.pid) {
            console.log(process.pid);
        }
        return new Response("Welcome to Bun!");
    },
});

console.log(`Listening on localhost:${server.port}`);

cluster.ts

import os from "node:os";

const numCPUs = os.cpus().length;
for (let i = 0; i < numCPUs; i++) {
    Bun.spawn(["bun", "index.ts"], {
        stdio: ["inherit", "inherit", "inherit"],
        env: { ...process.env },
    });
}

@rgillan
Copy link

rgillan commented Feb 14, 2024

Actually the feature for Bun.serve to allow port reuse (reusePort:true) and simple Bun.spawn of a number of processes works a treat. We have refactored a node:cluster websocket application using this simple approach and found it to be quite straightforward (on Linux at least), sharing both 443 and 80 (hsts). The ipc comms makes it a pretty simple drop in replacement with some simple rewrites. Subsequent websocket connections are load balanced by the OS in round robin. Still need to load test but functional.

@chlorophant
Copy link

We haven't implemented the Node.js cluster module yet.

Is there a timeline on this? Would love to have this feature!

@isaadabbasi
Copy link

Just came to this thread to tell, all the benchmark blogs n videos are comparing nodejs (clustered), Go (which is natively clustered) vs Bun. Though Bun outperform node on single process mode but its really not good for general sentiment build up.
It'd be really hard to educate the masses on fair grounds of comparison. If we could implement clustered mode that would be really great.

@antn9x
Copy link

antn9x commented Mar 7, 2024

I hope this feature release soon.

@waghanza
Copy link

waghanza commented Mar 7, 2024

Just came to this thread to tell, all the benchmark blogs n videos are comparing nodejs (clustered), Go (which is natively clustered) vs Bun.

Not really https://web-frameworks-benchmark.netlify.app/result?l=javascript is comparing node vs bun on with clustering for both of them. Clustering could be done, but it depends ... It could be useless, with some architecture, to have clustering mode

@rgillan
Copy link

rgillan commented Mar 7, 2024

So in my opinion having used node:cluster for many years (and the cluster module pre integration), the ability to reuse sockets in the Bun.serve implementation pretty much removes the need for node:cluster support in Bun for some of the use cases. The IPC channel support is identical syntax, and things like http/s and websocket server port sharing just work out of the box on Linux. Spawn separate workers and reuse the ports. Reach out if you need any guidance but we've pretty much deprecated the need for the cluster capability with what Bun already has implemented. Cheers Rob

@AlexanderEpolite
Copy link

So in my opinion having used node:cluster for many years (and the cluster module pre integration), the ability to reuse sockets in the Bun.serve implementation pretty much removes the need for node:cluster support in Bun for most of the use cases. The IPC channel support is identical syntax, and things like http/s and websocket server port sharing just work out of the box on Linux. Spawn separate workers and reuse the ports. Reach out if you need any guidance but we've pretty much deprecated the need for the cluster capability with what Bun already has implemented. Cheers Rob

What if I want to have multiple instances of smtp-server running on port 25? Only other option would be nginx, but that comes with its own set of issues.

@rgillan
Copy link

rgillan commented Mar 8, 2024

So in my opinion having used node:cluster for many years (and the cluster module pre integration), the ability to reuse sockets in the Bun.serve implementation pretty much removes the need for node:cluster support in Bun for most of the use cases. The IPC channel support is identical syntax, and things like http/s and websocket server port sharing just work out of the box on Linux. Spawn separate workers and reuse the ports. Reach out if you need any guidance but we've pretty much deprecated the need for the cluster capability with what Bun already has implemented. Cheers Rob

What if I want to have multiple instances of smtp-server running on port 25? Only other option would be nginx, but that comes with its own set of issues.

Understood, and yes you'd need to handle that externally (nginx, possibly pm2 would be another option but not sure) Another approach we have done in the nodejs world is have a single process handle the raw port, then workers doing what's needed. I've modified my comment to say some rather than most

@Ivanmatthew
Copy link

Ivanmatthew commented Mar 25, 2024

+1 on this. The lack of node:cluster implementation is probably the main reason we are not switching to Bun right now.

+1

So in my opinion having used node:cluster for many years (and the cluster module pre integration), the ability to reuse sockets in the Bun.serve implementation pretty much removes the need for node:cluster support in Bun for some of the use cases. The IPC channel support is identical syntax, and things like http/s and websocket server port sharing just work out of the box on Linux. Spawn separate workers and reuse the ports. Reach out if you need any guidance but we've pretty much deprecated the need for the cluster capability with what Bun already has implemented. Cheers Rob

The use-case would still be to reinforce Bun's statement of being a "drop-in" replacement for Node, since most of the functionality that entails the cluster module is apparently already implemented, I hope some of the code can be reused for a node:cluster module (mock?).

@snorremd
Copy link

On M1 Mac OS 8 cores, it does not work. On linux, Ubuntu 22, 2 cores I could get a good result. Sending concurrent requests to Bun server that console log the process.id numbers, we get different results.

Just for any other MacOS user like me coming to this thread to find out why reusePort is not working. It seems this feature works different on older FreeBSD and Darwin than Linux according to this StackOverflow thread. On MacOS the SO_REUSEPORT implementation does not round robin the TCP requests. Instead it sends the requests to the last process to attach to the socket.

Not sure if Darwin will ever implement this or not. So for the time being MacOS users will need to put a proxy in front of their Bun servers to support multiple process request handling.

@Bytedefined
Copy link

Would be great to see support sometime soon!

@elliotthill
Copy link

For a lot of us running regular servers, like ec2 instances, we cannot run Bun in production due to this.

Yes its possible to rewrite your app to use bun.serve() or rearchitect it to run on single threaded containers, but thats not really a drop in replacement as is claimed.

Given its the 12th most thumbs up'd issue out of ~2k, can it be added to the roadmap?

@mrtcmn
Copy link

mrtcmn commented May 2, 2024

This is power of the nodejs. I'll waiting node:cluster implemetation for migrate my all servers to bun.

@lodembeep
Copy link

What if you need clustering for tasks other than serving http requests ?

Clustering is important for non web tasks, i usually spawn workers on server side for CPU intensive tasks, nothing related to serving at all.

@Jarred-Sumner
Copy link
Collaborator

We are planning to implement node:cluster towards the end of this month.

@lodembeep
Copy link

We are planning to implement node:cluster towards the end of this month.

Awesome !!! I will spread the word :)

@haimev
Copy link

haimev commented May 21, 2024

cool! great news

@liudonghua123
Copy link
Contributor

I tried the latest bun 1.1.9. And it seemed not support currently. Hope next release could support it.

 > bun server.js
Primary 11780 is running
14 |   warned.add(feature), console.warn(new NotImplementedError(feature, issue));
15 | }, $;
16 |
17 | class NotImplementedError extends Error {
18 |   code;
19 |   constructor(feature, issue) {
                               ^
NotImplementedError: node:cluster is not yet implemented in Bun. Track the status & thumbs up the issue: https://github.com/oven-sh/bun/issues/2428
 code: "ERR_NOT_IMPLEMENTED"

      at new NotImplementedError (internal:shared:19:27)
      at internal:shared:2:69
      at fork (node:cluster:25:13)
      at D:\code\node\playground\cluster\server.js:13:5

Bun v1.1.9 (Windows x64)

 >

@i8ramin
Copy link

i8ramin commented May 27, 2024

Hello has anyone successfully been able to use pm2 with bun compiled node binary? i've tried many different commands and variations but cannot figure it out. any help would be greatly appreciated.

@techsin
Copy link

techsin commented May 29, 2024

is it out?

@nektro nektro self-assigned this May 30, 2024
@nektro nektro linked a pull request May 31, 2024 that will close this issue
@dienstbereit
Copy link

Hello has anyone successfully been able to use pm2 with bun compiled node binary? i've tried many different commands and variations but cannot figure it out. any help would be greatly appreciated.

I assume that as soon as node:cluster is implemented, bun will also run with pm2 in cluster mode out-of-the-box. At least I hope so ;-)

@ajimix
Copy link

ajimix commented Jun 9, 2024

We are planning to implement node:cluster towards the end of this month.

+1 if you are here in June or later, waiting for it to be implemented 😄

@Jarred-Sumner
Copy link
Collaborator

@nektro is working on this, please follow along in #11492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working node.js Compatibility with Node.js APIs
Projects
None yet
Development

Successfully merging a pull request may close this issue.