Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest versions of Bun have broken use of confirm() prompts. #5985

Closed
infrahead opened this issue Sep 23, 2023 · 2 comments · Fixed by #5986
Closed

Latest versions of Bun have broken use of confirm() prompts. #5985

infrahead opened this issue Sep 23, 2023 · 2 comments · Fixed by #5986
Labels
bug Something isn't working

Comments

@infrahead
Copy link

infrahead commented Sep 23, 2023

What version of Bun is running?

1.0.3

What platform is your computer?

Linux 5.15.90.1-microsoft-standard-WSL2 x86_64 x86_64

What steps can reproduce the bug?

Had written scripts that used to work, and had checkpoints similar to following...
if ( confirm('Proceed?') ) // never true

No matter what enter in terminal, "y", "Y", "yes", confirm always returns false now

What is the expected behavior?

for a value of y, return true

What do you see instead?

returns false for any value

Additional information

No response

@infrahead infrahead added the bug Something isn't working label Sep 23, 2023
@Jarred-Sumner
Copy link
Collaborator

confirming that confirm returns false

I don't think we have tests for confirm right now

@infrahead
Copy link
Author

infrahead commented Sep 23, 2023

Starting to think you are a bot @Jarred-Sumner ;). To be clear, this was working for some time, and I'm not sure which version broke it, as only just reran a bunch of infrastructure scripting I had moved to Bun.

I'll try to write some tests (as part of learning Bun testing) to paste here if that is any help

Jarred-Sumner added a commit that referenced this issue Sep 24, 2023
Jarred-Sumner added a commit that referenced this issue Sep 24, 2023
* Fixes #5985

* Update confirm-fixture.js

---------

Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants