Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node:os): cpus bugfix #10879

Merged
merged 4 commits into from
May 7, 2024
Merged

fix(node:os): cpus bugfix #10879

merged 4 commits into from
May 7, 2024

Conversation

dylan-conway
Copy link
Collaborator

What does this PR do?

Code was assuming line lengths were not longer than 1024 * 8 bytes. Removed std.io.Reader

fixes #10877

How did you verify your code works?

CI

Copy link

github-actions bot commented May 7, 2024

@dylan-conway, your commit has failing tests :(

💪 4 failing tests Darwin AARCH64

💻 3 failing tests Darwin x64 baseline

💻 3 failing tests Darwin x64

🐧💪 1 failing tests Linux AARCH64

🪟💻 9 failing tests Windows x64 baseline

🪟💻 7 failing tests Windows x64

View logs

@Jarred-Sumner Jarred-Sumner merged commit 288b540 into main May 7, 2024
40 of 52 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dylan/fix-cpus-bug branch May 7, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Failed to get cpu information" on supported architecture
2 participants