-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sloppily written test #10976
Fix sloppily written test #10976
Conversation
2b68b72
to
658c469
Compare
it.skipIf(!process.env.TEST_INFO_STRIPE)("should be able to query a charge", async () => { | ||
it.skipIf(!isBunCI && !process.env.TEST_INFO_STRIPE)("should be able to query a charge", async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what issues did you have running it locally?
let err = await new Response(stderr).text(); | ||
expect(err).not.toContain("panic:"); | ||
expect(err).not.toContain("error:"); | ||
expect(err).not.toContain("warn:"); | ||
let out = await new Response(stdout).text(); | ||
expect(await exited).toBe(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was done the other way so that you can see what the error was when it failed and nothing when it succeeds
What does this PR do?
Fix sloppily written test (cc @nektro):
"stripe"
into the bun repository instead of the temporary test folderbun install
String.raw
usage is unnecessarybun:test
This also:
bun install
in/package.json
ortest/package.json
from inside a test fail so that we don't runbun install
in the wrong directory again in a testHow did you verify your code works?
Ran the stripe test locally