Add native EventEmitter #1123
Merged
Add native EventEmitter #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| UNUSED_PARAM(callFrame); | ||
| auto& impl = castedThis->wrapped(); | ||
| if (UNLIKELY(callFrame->argumentCount() < 1)) | ||
| return throwVMError(lexicalGlobalObject, throwScope, createNotEnoughArgumentsError(lexicalGlobalObject)); |
There was a problem hiding this comment.
later this will need to be a node error with the code set to match
We have that in Zig but not in C++ yet
| JSC::VM& vm = lexicalGlobalObject->vm(); | ||
| GlobalObject* globalObject = reinterpret_cast<GlobalObject*>(lexicalGlobalObject); | ||
|
|
||
| exportNames.append(JSC::Identifier::fromString(vm, "EventEmitter"_s)); |
There was a problem hiding this comment.
We need to export both the class but also the properties of the class
<ref *1> [Function: EventEmitter] {
once: [AsyncFunction: once],
on: [Function: on],
getEventListeners: [Function: getEventListeners],
EventEmitter: [Circular *1],
usingDomains: false,
captureRejectionSymbol: Symbol(nodejs.rejection),
captureRejections: [Getter/Setter],
EventEmitterAsyncResource: [Getter],
errorMonitor: Symbol(events.errorMonitor),
defaultMaxListeners: [Getter/Setter],
setMaxListeners: [Function (anonymous)],
init: [Function (anonymous)],
listenerCount: [Function (anonymous)]
}
There was a problem hiding this comment.
but maybe its fine if its the default export too
| { | ||
| if (auto* target = jsDynamicCast<JSEventEmitter*>(thisValue)) | ||
| return makeUnique<JSEventEmitterWrapper>(target->wrapped(), *target); | ||
| if (auto* object = jsDynamicCast<JSObject*>(thisValue)) { |
There was a problem hiding this comment.
Suggested change
| if (auto* object = jsDynamicCast<JSObject*>(thisValue)) { | |
| if (auto* object = jsDynamicCast<JSNonFinalObject*>(thisValue)) { |
There was a problem hiding this comment.
I think that will handle the case where it's a constructor or prototype
| // use `mapPrivateName` as it is not occupied. | ||
| auto emitterTag = WebCore::clientData(vm)->builtinNames().mapPrivateName(); | ||
| JSC::JSValue value = object->getDirect(vm, emitterTag); | ||
| if (!value) { |
There was a problem hiding this comment.
tbh i'm not 100% sure if this should be !value.isUndefined or !value
maybe we want
Suggested change
| if (!value) { | |
| if (!value || value.isUndefined()) { |
There was a problem hiding this comment.
at least for the express example, !value works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.