-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: make test/js/bun/shell/commands/rm.test.ts less flaky #11243
base: main
Are you sure you want to change the base?
Conversation
if this fails with this remedy I'll move it to a separate file and do the install outside the test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cause of flakiness is bun install
making external network requests that take potentially a long time.
This test isn't meant to test bun install. It's meant to test rm
. So let's just not run bun install
, and instead create a big folder with a bunch of files and then verify that recursively deleting the folder works.
typical times for the node_modules test range from 2713.78ms to 9518.02ms
slightly increasing the timeout length and lowering the parallelism should make this much less flaky to network conditions