Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: make test/js/bun/shell/commands/rm.test.ts less flaky #11243

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nektro
Copy link
Contributor

@nektro nektro commented May 22, 2024

typical times for the node_modules test range from 2713.78ms to 9518.02ms

slightly increasing the timeout length and lowering the parallelism should make this much less flaky to network conditions

@nektro
Copy link
Contributor Author

nektro commented May 22, 2024

if this fails with this remedy I'll move it to a separate file and do the install outside the test

Copy link
Contributor

@nektro, your commit has failing tests :(

💪 2 failing tests Darwin AARCH64

💻 3 failing tests Darwin x64 baseline

💻 4 failing tests Darwin x64

🐧🖥 1 failing tests Linux x64 baseline

🐧🖥 2 failing tests Linux x64

🪟💻 11 failing tests Windows x64 baseline

🪟💻 11 failing tests Windows x64

View logs

@nektro nektro requested a review from Jarred-Sumner May 22, 2024 01:10
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cause of flakiness is bun install making external network requests that take potentially a long time.

This test isn't meant to test bun install. It's meant to test rm. So let's just not run bun install, and instead create a big folder with a bunch of files and then verify that recursively deleting the folder works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants