fix: broken README links #1148
Merged
fix: broken README links #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When viewing the DB benchmark, I noticed the link
404'd. After running bun through markdown-link-check, I found 3 dead links.DB Link
Found the commit SHA that the
curlcommand downloads (in the download.sh file)Pointer Conversion
Used
git log -L '/val instanceof ArrayBuffer/,+1:src/bun.js/ffi.exports.js'to find commit 98393ca to change the referenced linesDynamic Requires
This one is just odd, not exactly sure what happened there. But the link now works (insert shrug emote here)?
Let me know if any of these updated links are wrong and I'll take another pass at em!