On Windows, support Bun.stdin
, Bun.stdout
, Bun.stderr
in Bun.write
when the other argument is a file
#12411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The following now work as expected on Windows:
This also addresses a bug where we would have an assertion failure when passing a
NUL
file path on Windows. In most cases, we will now use the WindowsGetFinalPathByHandleW
function instead of Zig's implementation (ziglang/zig#18756).Fixes #12404
Fixes #12134
Fixes #11352 (most likely)
Fixes #10914 (most likely)
How did you verify your code works?
The
BUN_FEATURE_FLAG_DISABLE_UV_FS_COPYFILE
environment variable forces the code path which does a read-write loop inBun.write
. We re-run the tests forBun.write
with this environment variable set on Windows. Also, added a couple more tests.