Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expect) fix behavior of .not.throw when receiving a string #13272

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

cirospaciari
Copy link
Collaborator

What does this PR do?

Fix: #13267

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Added a test

@cirospaciari cirospaciari requested review from a team and dylan-conway and removed request for a team August 13, 2024 19:53
Copy link
Collaborator

@dylan-conway dylan-conway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Jarred-Sumner Jarred-Sumner merged commit c229da8 into main Aug 14, 2024
45 checks passed
@Jarred-Sumner Jarred-Sumner deleted the ciro/expecte-not-throw branch August 14, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault with expect().not.toThrow(/regex/)
4 participants