Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement all pending resolve methods in DNS #1903

Merged
merged 15 commits into from Jan 27, 2023
Merged

Implement all pending resolve methods in DNS #1903

merged 15 commits into from Jan 27, 2023

Conversation

cirospaciari
Copy link
Collaborator

@cirospaciari cirospaciari commented Jan 25, 2023 •
edited

  • resolveSrv
  • resolveTxt
  • resolveNs
  • resolvePtr
  • resolveCname
  • resolveAny will not implement yet
  • resolveCaa
  • resolveMx
  • resolveNaptr
  • resolveSoa
  • dns.resolve( hostname, rrtype, callback )

Related to #1744

@cirospaciari cirospaciari marked this pull request as draft January 25, 2023 21:41
@cirospaciari
Copy link
Collaborator Author

cirospaciari commented Jan 26, 2023 •
edited

query of type ANY seems to be deprecated/obsolete https://blog.cloudflare.com/rfc8482-saying-goodbye-to-any/
So I will make this ready for review and take a look in resolveAny only after the rest of DNS module is implemented

@cirospaciari cirospaciari changed the title [WIP] Implement all pending resolve methods in DNS Implement all pending resolve methods in DNS Jan 26, 2023
@cirospaciari cirospaciari marked this pull request as ready for review January 26, 2023 20:38
@cirospaciari cirospaciari changed the title Implement all pending resolve methods in DNS Implement all pending resolve methods in DNS (Except ANY) Jan 26, 2023
@Electroid Electroid changed the title Implement all pending resolve methods in DNS (Except ANY) Implement all pending resolve methods in DNS Jan 26, 2023
Jarred-Sumner
Jarred-Sumner reviewed Jan 27, 2023
View reviewed changes
src/bun.js/bindings/ZigGlobalObject.cpp
@@ -3325,8 +3334,26 @@ void GlobalObject::installAPIGlobals(JSClassRef* globals, int count, JSC::VM& vm
JSC::JSObject* dnsObject = JSC::constructEmptyObject(this);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that there's a bunch of functions on this guy let's make it a LazyProperty so that we skip creating these 10 functions at start

@Jarred-Sumner Jarred-Sumner merged commit 6d06606 into main Jan 27, 2023
@Jarred-Sumner Jarred-Sumner deleted the ciro/resolve-dns branch January 27, 2023 02:36
@Jarred-Sumner
Copy link
Collaborator

great work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarred-Sumner Jarred-Sumner Jarred-Sumner left review comments

@Electroid Electroid Electroid left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cirospaciari @Jarred-Sumner @Electroid