Expose Dirent and Stats #1998
Merged
Expose Dirent and Stats #1998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great - thank you We have a separate BigIntStats class but it is probably bad to have a separate class for it since I don't think Node does that |
|
Crap! I didn't expect such a quick merge! I wasn't able to launch tests locally using the "changed" bun version. I see that the tests don't pass on main because of that now :(. If you could direct me to how to "compile" locally a new version and use it to launch the specs I can work on fixing that. |
|
@Jarred-Sumner not sure if you will see it so I'm pinging just in case :D |
|
I forgot we hadn’t ported over Stats to the new Zig bindings which is why I missed that before merging Went ahead and ported it earlier tonight |
Electroid
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Expose dirent and stats * Expose Dirent and Stats inside fs * Add tests for Dirent and Stats exposing * Automatically generate bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.