[install] assorted fixes & improvements #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- take `peerDependencies` into account during package placement - do not recursively resolve `workspaces` (matches `npm`) - link binaries to non-root packages correctly - prune empty nodes during dependency tree construction - support non-standard `workspace:` specifier
| // verilog.tar.gz | ||
| // verilog/repo | ||
| 'v' => { | ||
| if (isTarball(dependency)) return .tarball; | ||
| if (isGitHubRepoPath(dependency)) return .github; | ||
| return .npm; | ||
| if (dependency.len == 1) return .dist_tag; |
| } else { | ||
| if (this.global_bin_dir.fd >= std.math.maxInt(std.os.fd_t)) { | ||
| this.err = error.MissingGlobalBinDir; | ||
| return; | ||
| } | ||
|
|
||
| @memcpy(&target_buf, this.global_bin_path.ptr, this.global_bin_path.len); | ||
| std.mem.copy(u8, &target_buf, this.global_bin_path); |
There was a problem hiding this comment.
std.mem.copy is slower than memcpy
but memcpy musn't overlap
we probably should have a wrapper that makes this stuff safer honestly
like a
bun.concat(dest, &.{"a", "b", "c", "d"})
There was a problem hiding this comment.
Ah okay, I was just going for consistency for all usages within this function - will try and make that helper function now.
|
Thank you |
Electroid
pushed a commit
that referenced
this pull request
Feb 17, 2023
- take `peerDependencies` into account during package placement - do not recursively resolve `workspaces` (matches `npm`) - link binaries to non-root packages correctly - prune empty nodes during dependency tree construction - support non-standard `workspace:` specifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
peerDependenciesinto account during package placementworkspaces(matchesnpm)workspace:specifier