Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark currently known test fails as .todo #3052

Merged
merged 9 commits into from
Jun 1, 2023

Conversation

paperdave
Copy link
Collaborator

@paperdave paperdave commented May 24, 2023

clear to merge if tests pass

@github-actions
Copy link

github-actions bot commented May 24, 2023

@paperdave 2 files with test failures on linux-x64-baseline:

  • test/js/bun/websocket/websocket-server.test.ts
  • test/js/node/child_process/child_process-node.test.js

View test output

#670be34a738b300d8cb3eb01e26a19fdc122fe4e

@github-actions
Copy link

github-actions bot commented May 24, 2023

@paperdave 2 files with test failures on linux-x64:

  • test/js/bun/websocket/websocket-server.test.ts
  • test/js/node/child_process/child_process-node.test.js

View test output

#670be34a738b300d8cb3eb01e26a19fdc122fe4e

@github-actions
Copy link

github-actions bot commented May 24, 2023

@paperdave 4 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/web/fetch/fetch-leak.test.js
  • test/js/web/timers/setTimeout.test.js

View test output

#670be34a738b300d8cb3eb01e26a19fdc122fe4e

@paperdave paperdave force-pushed the dave/mark-known-fails-as-todo branch 3 times, most recently from d3a53c9 to e6160b6 Compare May 26, 2023 19:00
@paperdave paperdave force-pushed the dave/mark-known-fails-as-todo branch from 98995d1 to 02f61b5 Compare June 1, 2023 20:52
@paperdave paperdave force-pushed the dave/mark-known-fails-as-todo branch from 452a666 to 4a81f83 Compare June 1, 2023 21:36
@Jarred-Sumner Jarred-Sumner merged commit 4378ef8 into main Jun 1, 2023
10 of 12 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dave/mark-known-fails-as-todo branch June 1, 2023 21:37
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

@paperdave prettier reported errors

[warn] src/bun.js/events.exports.js
[warn] Code style issues found in the above file. Forgot to run Prettier?
error: "prettier" exited with code 1 (SIGHUP)
Checking formatting...

To one-off fix this manually, run:

bun fmt

You might need to run bun install locally and configure your text editor to auto-format on save.

#670be34a738b300d8cb3eb01e26a19fdc122fe4e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants