New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3161 #3174

Merged

Jarred-Sumner merged 3 commits into main from jarred/fixes-3161

Jun 2, 2023

Collaborator

Jarred-Sumner commented Jun 2, 2023

This fixes #3161 without changing the module evaluation order (unlike #3173)

it seems that the WithScope is being collected prematurely.

Jarred-Sumner added 2 commits

June 2, 2023 02:23


          Fixes #3161

cd67cf0


          Fix the error message

eb92069

github-actions bot commented Jun 2, 2023 •

edited

❌ @Jarred-Sumner 2 files with test failures on linux-x64:

test/js/bun/websocket/websocket-server.test.ts
test/js/node/child_process/child_process-node.test.js

View test output

^{#1a199018671f2d5ce284d3c64d9e2e09be81ca80}

github-actions bot commented Jun 2, 2023 •

edited

❌ @Jarred-Sumner 2 files with test failures on linux-x64-baseline:

test/js/bun/websocket/websocket-server.test.ts
test/js/node/child_process/child_process-node.test.js

View test output

^{#1a199018671f2d5ce284d3c64d9e2e09be81ca80}


          woops

b8c0d28

github-actions bot commented Jun 2, 2023

❌ @Jarred-Sumner 4 files with test failures on bun-darwin-x64-baseline:

test/js/bun/spawn/spawn-streaming-stdin.test.ts
test/js/bun/sqlite/sqlite.test.js
test/js/bun/util/sleepSync.test.ts
test/js/web/timers/setTimeout.test.js

View test output

^{#1a199018671f2d5ce284d3c64d9e2e09be81ca80}

Jarred-Sumner merged commit 97c5225 into main

14 of 19 checks passed

Jarred-Sumner deleted the jarred/fixes-3161 branch

June 2, 2023 11:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment