Improvements to WebSocket and ServerWebSocket

[Electroid]

import { serve } from "bun";

serve({
  fetch(request, server) {
    if (server.upgrade(request)) {
      return;
    }
    return new Response();
  },
  websocket: {
    open(ws) {
      ws.ping();
    },
    ping(ws, data) {
      ws.pong(data);
    },
    pong(ws, data) {
      ws.terminate();
    }
  }
});

New stuff

• Default binaryType in WebSocket is now "nodebuffer" to match the server [breaking]
• ws.terminate() - abruptly closes the connection
• ws.ping(data?) - sends a ping
• ws.pong(data?) - sends a pong

Bug fixes

• ws.close(1000, "non-ascii") was not encoded properly
• hostname and pathname were not encoded properly on WebSocket upgrade
• idleTimeout could crash if between (0, 8] due to uws limitation

[github-actions]

❌ @Electroid prettier reported errors

[warn] test/js/bun/websocket/websocket-server.test.ts
[warn] test/js/first_party/ws/ws.test.ts
[warn] src/js/thirdparty/ws.js
[warn] Code style issues found in 3 files. Forgot to run Prettier?
error: "prettier" exited with code 1 (SIGHUP)
Checking formatting...

To one-off fix this manually, run:

bun fmt

You might need to run bun install locally and configure your text editor to auto-format on save.

^{#92ce42b2ca7bccacae9f5e1451c756d1072f08d9}

[github-actions]

❌ @Electroid 11 files with test failures on bun-darwin-aarch64:

• test/bundler/bundler_compile.test.ts
• test/cli/install/bun-link.test.ts
• test/cli/install/bun-run.test.ts
• test/cli/install/bunx.test.ts
• test/js/bun/net/socket.test.ts
• test/js/bun/spawn/spawn.test.ts
• test/js/bun/test/test-test.test.ts
• test/js/bun/util/unsafe.test.js
• test/js/node/child_process/child_process-node.test.js
• test/js/node/watch/fs.watch.test.ts
• test/js/web/fetch/fetch-leak.test.js

View test output

^{#92ce42b2ca7bccacae9f5e1451c756d1072f08d9}

[github-actions]

❌ @Electroid 4 files with test failures on linux-x64:

• test/cli/install/bun-link.test.ts
• test/cli/install/bun-run.test.ts
• test/js/node/watch/fs.watch.test.ts
• test/js/web/fetch/fetch-leak.test.js

View test output

^{#92ce42b2ca7bccacae9f5e1451c756d1072f08d9}

[github-actions]

❌ @Electroid 4 files with test failures on linux-x64-baseline:

• test/cli/install/bun-link.test.ts
• test/cli/install/bun-run.test.ts
• test/js/node/watch/fs.watch.test.ts
• test/js/web/fetch/fetch-leak.test.js

View test output

^{#92ce42b2ca7bccacae9f5e1451c756d1072f08d9}

[github-actions]

❌ @Electroid 8 files with test failures on bun-darwin-x64-baseline:

• test/cli/install/bun-link.test.ts
• test/cli/install/bun-run.test.ts
• test/js/bun/spawn/spawn-streaming-stdin.test.ts
• test/js/bun/spawn/spawn.test.ts
• test/js/bun/sqlite/sqlite.test.js
• test/js/bun/util/sleepSync.test.ts
• test/js/third_party/webpack/webpack.test.ts
• test/js/web/timers/setTimeout.test.js

View test output

^{#92ce42b2ca7bccacae9f5e1451c756d1072f08d9}

[paperdave]

is the binary type default on the global WebSocket client? because that kind of breaking change would break the web websocket spec- ideally those should match the browser

[Jarred-Sumner]

Bun already doesn’t support Blob for binaryType Note that websocket messages say whether binary or text, it’s not a decision we make

…

On Fri, Jun 9, 2023 at 9:31 AM dave caruso ***@***.***> wrote: is the binary type default on the global WebSocket client? because that kind of breaking change would break the web websocket spec- ideally those should match the browser — Reply to this email directly, view it on GitHub <#3257 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFNGS34IUBTM5DXOE4HTJDXKNFW7ANCNFSM6AAAAAAZARZOLI> . You are receiving this because your review was requested.Message ID: ***@***.***>

[Jarred-Sumner]

LGTM after tests run

[Electroid]

Looks like there's a flaky test with the websocket server, will take a look. (it's probably uws related)