New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash with .env files that are exactly 159 bytes long #3369

Merged

Jarred-Sumner merged 2 commits into main from jarred/env-159

Jun 21, 2023

Collaborator

Jarred-Sumner commented Jun 21, 2023

We were writing a zero 1 byte out of bounds of the array

Jarred-Sumner added 2 commits

June 20, 2023 20:37


          Fix crash with .env files that are exactly 158 bytes and a newline ch…

fa554b2

…aracter


          Update env_loader.zig

da7a182

github-actions bot commented Jun 21, 2023 •

edited

✅ zig fmt errors have been resolved. Thank you.

^{#8f614c6a40ed05de16e94686caae8505e4f43e4d}
^{zig v0.11.0-dev.2571+31738de28}

github-actions bot commented Jun 21, 2023

❌ @Jarred-Sumner 8 files with test failures on bun-darwin-aarch64:

test/bundler/bundler_browser.test.ts
test/bundler/esbuild/default.test.ts
test/bundler/esbuild/importstar.test.ts
test/cli/install/bunx.test.ts
test/js/bun/net/socket.test.ts
test/js/bun/test/test-test.test.ts
test/js/bun/util/inspect.test.js
test/js/web/fetch/fetch-leak.test.js

View test output

^{#8f614c6a40ed05de16e94686caae8505e4f43e4d}

github-actions bot commented Jun 21, 2023

❌ @Jarred-Sumner 6 files with test failures on linux-x64:

test/bundler/bundler_browser.test.ts
test/bundler/esbuild/default.test.ts
test/bundler/esbuild/importstar.test.ts
test/cli/install/bunx.test.ts
test/js/bun/util/inspect.test.js
test/js/bun/websocket/websocket-server.test.ts

View test output

^{#8f614c6a40ed05de16e94686caae8505e4f43e4d}

github-actions bot commented Jun 21, 2023

❌ @Jarred-Sumner 6 files with test failures on linux-x64-baseline:

test/bundler/bundler_browser.test.ts
test/bundler/esbuild/default.test.ts
test/bundler/esbuild/importstar.test.ts
test/cli/install/bunx.test.ts
test/js/bun/util/inspect.test.js
test/js/bun/websocket/websocket-server.test.ts

View test output

^{#8f614c6a40ed05de16e94686caae8505e4f43e4d}

Jarred-Sumner merged commit f81c7f1 into main

15 of 19 checks passed

Jarred-Sumner deleted the jarred/env-159 branch

June 21, 2023 04:17

github-actions bot commented Jun 21, 2023

❌ @Jarred-Sumner 8 files with test failures on bun-darwin-x64-baseline:

test/bundler/bundler_browser.test.ts
test/bundler/esbuild/default.test.ts
test/bundler/esbuild/importstar.test.ts
test/cli/install/bunx.test.ts
test/js/bun/spawn/spawn-streaming-stdin.test.ts
test/js/bun/sqlite/sqlite.test.js
test/js/bun/util/sleepSync.test.ts
test/js/web/timers/setTimeout.test.js

View test output

^{#8f614c6a40ed05de16e94686caae8505e4f43e4d}

trnxdev mentioned this pull request

Segfault when .env is exactly 159 bytes #3136

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment