[jest] fix lifecycle hook execution order #3461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } else if (DescribeScope.active) |scope| { | ||
| // calling Bun.jest() within (already active) module | ||
| if (scope.parent != null) return; |
There was a problem hiding this comment.
What happens if you call Bun.jest(import.meta.path) from another file, use that same file repeatedly? They may not use a new instance of Bun.jest() each call. Basically, expect and whatnot needs to be thought of as globals even though they are not globals.
There was a problem hiding this comment.
Here we explicitly avoid any child describe() instances to be replaced by locally created "root" instance when Bun.jest(path) is called.
alexlamsl
force-pushed
the
jest-before-after
branch
from
db431bd
to
7451d45
Compare
alexlamsl
force-pushed
the
jest-before-after
branch
from
7451d45
to
fa281f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.