Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] patch fs.watch sym link #3481

Merged
merged 3 commits into from
Jul 3, 2023
Merged

[fix] patch fs.watch sym link #3481

merged 3 commits into from
Jul 3, 2023

Conversation

cirospaciari
Copy link
Collaborator

@cirospaciari cirospaciari commented Jul 1, 2023

Fix #3469 (comment)

  • fix code
  • add tests

@cirospaciari cirospaciari marked this pull request as ready for review July 1, 2023 15:58
@github-actions
Copy link

github-actions bot commented Jul 1, 2023

@Jarred-Sumner 11 files with test failures on bun-darwin-aarch64:

  • test/cli/install/bun-run.test.ts
  • test/js/bun/net/socket.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/bun/websocket/websocket-server.test.ts
  • test/js/node/watch/fs.watch.test.js
  • test/js/third_party/prisma/prisma.test.ts
  • test/js/third_party/socket.io/socket.io-close.test.ts
  • test/js/third_party/socket.io/socket.io-connection-state-recovery.test.ts
  • test/js/web/fetch/fetch-leak.test.js
  • test/js/web/websocket/websocket.test.js

View test output

#06bb5289fbd47840ecfccba1f410d1559e55380b

@github-actions
Copy link

github-actions bot commented Jul 1, 2023

@Jarred-Sumner 8 files with test failures on linux-x64:

  • test/cli/install/bun-run.test.ts
  • test/js/bun/websocket/websocket-server.test.ts
  • test/js/node/watch/fs.watch.test.js
  • test/js/third_party/nodemailer/nodemailer.test.ts
  • test/js/third_party/prisma/prisma.test.ts
  • test/js/third_party/socket.io/socket.io-close.test.ts
  • test/js/third_party/socket.io/socket.io-connection-state-recovery.test.ts
  • test/js/web/websocket/websocket.test.js

View test output

#06bb5289fbd47840ecfccba1f410d1559e55380b

@github-actions
Copy link

github-actions bot commented Jul 1, 2023

@Jarred-Sumner 8 files with test failures on linux-x64-baseline:

  • test/cli/install/bun-run.test.ts
  • test/js/bun/websocket/websocket-server.test.ts
  • test/js/node/watch/fs.watch.test.js
  • test/js/third_party/nodemailer/nodemailer.test.ts
  • test/js/third_party/prisma/prisma.test.ts
  • test/js/third_party/socket.io/socket.io-close.test.ts
  • test/js/third_party/socket.io/socket.io-connection-state-recovery.test.ts
  • test/js/web/websocket/websocket.test.js

View test output

#06bb5289fbd47840ecfccba1f410d1559e55380b

@github-actions
Copy link

github-actions bot commented Jul 1, 2023

@Jarred-Sumner 12 files with test failures on bun-darwin-x64-baseline:

  • test/cli/install/bun-run.test.ts
  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/bun/util/sleepSync.test.ts
  • test/js/bun/websocket/websocket-server.test.ts
  • test/js/third_party/nodemailer/nodemailer.test.ts
  • test/js/third_party/prisma/prisma.test.ts
  • test/js/third_party/socket.io/socket.io-close.test.ts
  • test/js/third_party/socket.io/socket.io-connection-state-recovery.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js
  • test/js/web/websocket/websocket.test.js

View test output

#06bb5289fbd47840ecfccba1f410d1559e55380b

@cirospaciari cirospaciari force-pushed the ciro/patch-fs.watch branch 2 times, most recently from 8644aa5 to c8f7529 Compare July 3, 2023 13:49
@Jarred-Sumner Jarred-Sumner merged commit 034577c into main Jul 3, 2023
13 checks passed
@Jarred-Sumner Jarred-Sumner deleted the ciro/patch-fs.watch branch July 3, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fs.watch for symbolic links
2 participants