New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make HTTP Request struct use 8 bytes less memory #3483

Merged

Jarred-Sumner merged 2 commits into main from jarred/8-byte

Jul 1, 2023

Collaborator

Jarred-Sumner commented Jul 1, 2023

After: 304 bytes per request
Before: 312 bytes per request

Note: this does not include JS request object or JS response objects. Just the internal representation

Jarred-Sumner added 2 commits

July 1, 2023 13:06


          Make HTTP Request struct use 8 bytes less memory

58c0e16


          Update server.zig

d42368c

github-actions bot commented Jul 1, 2023

❌ @Jarred-Sumner 5 files with test failures on linux-x64:

test/cli/install/bun-run.test.ts
test/js/bun/websocket/websocket-server.test.ts
test/js/node/watch/fs.watch.test.js
test/js/web/fetch/fetch-leak.test.js
test/js/web/websocket/websocket.test.js

View test output

^{#dd636641cbda2ac905c16ccb029d1737b6cbdab0}

github-actions bot commented Jul 1, 2023

❌ @Jarred-Sumner 5 files with test failures on linux-x64-baseline:

test/cli/install/bun-run.test.ts
test/js/bun/websocket/websocket-server.test.ts
test/js/node/watch/fs.watch.test.js
test/js/web/fetch/fetch-leak.test.js
test/js/web/websocket/websocket.test.js

View test output

^{#dd636641cbda2ac905c16ccb029d1737b6cbdab0}

github-actions bot commented Jul 1, 2023

❌ @Jarred-Sumner 8 files with test failures on bun-darwin-aarch64:

test/cli/install/bun-run.test.ts
test/js/bun/net/socket.test.ts
test/js/bun/spawn/spawn-streaming-stdin.test.ts
test/js/bun/spawn/spawn.test.ts
test/js/bun/test/test-test.test.ts
test/js/bun/websocket/websocket-server.test.ts
test/js/web/fetch/fetch-leak.test.js
test/js/web/websocket/websocket.test.js

View test output

^{#dd636641cbda2ac905c16ccb029d1737b6cbdab0}

github-actions bot commented Jul 1, 2023

❌ @Jarred-Sumner 9 files with test failures on bun-darwin-x64-baseline:

test/cli/install/bun-run.test.ts
test/js/bun/spawn/spawn-streaming-stdin.test.ts
test/js/bun/spawn/spawn.test.ts
test/js/bun/sqlite/sqlite.test.js
test/js/bun/util/sleepSync.test.ts
test/js/bun/websocket/websocket-server.test.ts
test/js/third_party/webpack/webpack.test.ts
test/js/web/timers/setTimeout.test.js
test/js/web/websocket/websocket.test.js

View test output

^{#dd636641cbda2ac905c16ccb029d1737b6cbdab0}

Jarred-Sumner merged commit df10252 into main

15 of 20 checks passed

Jarred-Sumner deleted the jarred/8-byte branch

July 1, 2023 21:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment