New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use `BunString` in `SystemError` #3485

Merged

Jarred-Sumner merged 5 commits into main from jarred/system-error

Jul 2, 2023

Collaborator

Jarred-Sumner commented Jul 1, 2023

This fixes a crash that can happen when certain exceptions are thrown and GC'd introduced in Bun v0.6.12
This switches the SystemError type used for throwing exceptions with extra context to use bun.String instead of ZigString.
This makes usages of static strings go through the AtomString lookup table instead of leaking the ExternalStringImpl* type forever on each call
This adds a test that checks we don't crash as a result of GC'ing exceptions thrown by node:fs (SystemError)

Jarred-Sumner added 4 commits

July 1, 2023 16:27


          Use BunString in SystemError

9bed7b1


          Use Bun::toStringRef when we will de-ref strings

2de4b80


          Move napi_create_error to C++ to support code being a Symbol pote…

5d12b14

…ntially


          Update blob.zig

github-actions bot commented Jul 2, 2023 •

edited

❌ @Jarred-Sumner 9 files with test failures on bun-darwin-aarch64:

test/cli/install/bun-run.test.ts
test/js/bun/net/socket.test.ts
test/js/bun/spawn/spawn-streaming-stdin.test.ts
test/js/bun/spawn/spawn.test.ts
test/js/bun/test/test-test.test.ts
test/js/bun/util/error-gc-test.test.js
test/js/bun/websocket/websocket-server.test.ts
test/js/web/fetch/fetch-leak.test.js
test/js/web/websocket/websocket.test.js

View test output

^{#96a092fb8b14b473ddd23dc0ae91c4b51f6b1e82}

github-actions bot commented Jul 2, 2023 •

edited

❌ @Jarred-Sumner 5 files with test failures on linux-x64-baseline:

test/cli/install/bun-run.test.ts
test/js/bun/websocket/websocket-server.test.ts
test/js/node/watch/fs.watch.test.js
test/js/web/fetch/fetch-leak.test.js
test/js/web/websocket/websocket.test.js

View test output

^{#96a092fb8b14b473ddd23dc0ae91c4b51f6b1e82}

github-actions bot commented Jul 2, 2023 •

edited

❌ @Jarred-Sumner 5 files with test failures on linux-x64:

test/cli/install/bun-run.test.ts
test/js/bun/websocket/websocket-server.test.ts
test/js/node/watch/fs.watch.test.js
test/js/web/fetch/fetch-leak.test.js
test/js/web/websocket/websocket.test.js

View test output

^{#96a092fb8b14b473ddd23dc0ae91c4b51f6b1e82}


          Make this test less flaky

62b3cb6

Jarred-Sumner merged commit f00e2be into main

12 checks passed

Jarred-Sumner deleted the jarred/system-error branch

July 2, 2023 00:37

github-actions bot commented Jul 2, 2023

❌ @Jarred-Sumner 10 files with test failures on bun-darwin-x64-baseline:

test/cli/install/bun-run.test.ts
test/js/bun/spawn/spawn-streaming-stdin.test.ts
test/js/bun/sqlite/sqlite.test.js
test/js/bun/util/error-gc-test.test.js
test/js/bun/util/sleepSync.test.ts
test/js/bun/websocket/websocket-server.test.ts
test/js/third_party/webpack/webpack.test.ts
test/js/web/timers/setInterval.test.js
test/js/web/timers/setTimeout.test.js
test/js/web/websocket/websocket.test.js

View test output

^{#96a092fb8b14b473ddd23dc0ae91c4b51f6b1e82}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment