New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[node:buffer] Implement `isUtf8` and `isAscii` #3498

Merged

Jarred-Sumner merged 1 commit into main from jarred/buffer-utf

Jul 3, 2023

Collaborator

Jarred-Sumner commented Jul 2, 2023

This implements the isUtf8 and isAscii functions on the node:buffer module which Node.js added in v19.x


          [node:buffer] Implement isUtf8 and isAscii

2970cf1

Jarred-Sumner mentioned this pull request

utf-8-validate doesn't work with bun install due to not running postinstall script #3497

Closed

github-actions bot commented Jul 2, 2023

❌ @Jarred-Sumner 9 files with test failures on bun-darwin-aarch64:

test/cli/install/bun-run.test.ts
test/js/bun/net/socket.test.ts
test/js/bun/spawn/spawn.test.ts
test/js/bun/test/test-test.test.ts
test/js/bun/websocket/websocket-server.test.ts
test/js/third_party/socket.io/socket.io-close.test.ts
test/js/third_party/socket.io/socket.io-connection-state-recovery.test.ts
test/js/web/fetch/fetch-leak.test.js
test/js/web/websocket/websocket.test.js

View test output

^{#00d8caaa89ebeaf888bf104efcdfbfe3aff0d71a}

github-actions bot commented Jul 2, 2023

❌ @Jarred-Sumner 8 files with test failures on linux-x64:

test/cli/install/bun-run.test.ts
test/js/bun/websocket/websocket-server.test.ts
test/js/node/watch/fs.watch.test.js
test/js/third_party/prisma/prisma.test.ts
test/js/third_party/socket.io/socket.io-close.test.ts
test/js/third_party/socket.io/socket.io-connection-state-recovery.test.ts
test/js/web/fetch/fetch-leak.test.js
test/js/web/websocket/websocket.test.js

View test output

^{#00d8caaa89ebeaf888bf104efcdfbfe3aff0d71a}

github-actions bot commented Jul 2, 2023

❌ @Jarred-Sumner 8 files with test failures on linux-x64-baseline:

test/cli/install/bun-run.test.ts
test/js/bun/websocket/websocket-server.test.ts
test/js/node/watch/fs.watch.test.js
test/js/third_party/prisma/prisma.test.ts
test/js/third_party/socket.io/socket.io-close.test.ts
test/js/third_party/socket.io/socket.io-connection-state-recovery.test.ts
test/js/web/fetch/fetch-leak.test.js
test/js/web/websocket/websocket.test.js

View test output

^{#00d8caaa89ebeaf888bf104efcdfbfe3aff0d71a}

github-actions bot commented Jul 2, 2023

❌ @Jarred-Sumner 10 files with test failures on bun-darwin-x64-baseline:

test/cli/install/bun-run.test.ts
test/js/bun/dns/resolve-dns.test.ts
test/js/bun/spawn/spawn-streaming-stdin.test.ts
test/js/bun/sqlite/sqlite.test.js
test/js/bun/websocket/websocket-server.test.ts
test/js/third_party/socket.io/socket.io-close.test.ts
test/js/third_party/socket.io/socket.io-connection-state-recovery.test.ts
test/js/third_party/webpack/webpack.test.ts
test/js/web/timers/setTimeout.test.js
test/js/web/websocket/websocket.test.js

View test output

^{#00d8caaa89ebeaf888bf104efcdfbfe3aff0d71a}

Jarred-Sumner merged commit c3f8593 into main

14 of 20 checks passed

Jarred-Sumner deleted the jarred/buffer-utf branch

July 3, 2023 01:06

Jarred-Sumner added a commit that referenced this pull request


          [node:buffer] Implement isUtf8 and isAscii (#3498)

6528f5c

Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment