Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fast path for Base64 in btoa #3504

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Use fast path for Base64 in btoa #3504

merged 2 commits into from
Jul 3, 2023

Conversation

Jarred-Sumner
Copy link
Collaborator

No description provided.

@Jarred-Sumner Jarred-Sumner changed the title Use fast path for Base64 in atob Use fast path for Base64 in btoa Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 3, 2023 •
edited

❌ @Jarred-Sumner 8 files with test failures on linux-x64:

  • test/cli/install/bun-run.test.ts
  • test/js/bun/websocket/websocket-server.test.ts
  • test/js/node/watch/fs.watch.test.js
  • test/js/third_party/prisma/prisma.test.ts
  • test/js/third_party/socket.io/socket.io-close.test.ts
  • test/js/third_party/socket.io/socket.io-connection-state-recovery.test.ts
  • test/js/web/fetch/fetch-leak.test.js
  • test/js/web/websocket/websocket.test.js

View test output

#a52cf3419cde36d9c6fd804d700f70d3c22e216e

@github-actions
Copy link

github-actions bot commented Jul 3, 2023 •
edited

❌ @Jarred-Sumner 8 files with test failures on linux-x64-baseline:

  • test/cli/install/bun-run.test.ts
  • test/js/bun/websocket/websocket-server.test.ts
  • test/js/node/watch/fs.watch.test.js
  • test/js/third_party/prisma/prisma.test.ts
  • test/js/third_party/socket.io/socket.io-close.test.ts
  • test/js/third_party/socket.io/socket.io-connection-state-recovery.test.ts
  • test/js/web/fetch/fetch-leak.test.js
  • test/js/web/websocket/websocket.test.js

View test output

#a52cf3419cde36d9c6fd804d700f70d3c22e216e

@github-actions
Copy link

github-actions bot commented Jul 3, 2023 •
edited

❌ @Jarred-Sumner 11 files with test failures on bun-darwin-aarch64:

  • test/cli/install/bun-run.test.ts
  • test/js/bun/net/socket.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/bun/websocket/websocket-server.test.ts
  • test/js/node/child_process/child_process-node.test.js
  • test/js/node/http/node-http.test.ts
  • test/js/third_party/socket.io/socket.io-close.test.ts
  • test/js/third_party/socket.io/socket.io-connection-state-recovery.test.ts
  • test/js/web/fetch/fetch-leak.test.js
  • test/js/web/websocket/websocket.test.js

View test output

#a52cf3419cde36d9c6fd804d700f70d3c22e216e

@github-actions
Copy link

github-actions bot commented Jul 3, 2023 •
edited

❌ @Jarred-Sumner 10 files with test failures on bun-darwin-x64-baseline:

  • test/cli/install/bun-run.test.ts
  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/bun/websocket/websocket-server.test.ts
  • test/js/third_party/socket.io/socket.io-close.test.ts
  • test/js/third_party/socket.io/socket.io-connection-state-recovery.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js
  • test/js/web/websocket/websocket.test.js

View test output

#a52cf3419cde36d9c6fd804d700f70d3c22e216e

@Jarred-Sumner Jarred-Sumner merged commit eb90ce5 into main Jul 3, 2023
14 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/refactor-atob branch July 3, 2023 03:16
Jarred-Sumner added a commit that referenced this pull request Jul 3, 2023
@Jarred-Sumner
Use fast path for Base64 in btoa (#3504)
e164976 
* Use fast path for Base64 in `atob`

* Fix utf16, crash on linux

---------

Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Jarred-Sumner