Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tls] fix servername #3513

Merged
merged 4 commits into from
Jul 4, 2023
Merged

[tls] fix servername #3513

merged 4 commits into from
Jul 4, 2023

Conversation

cirospaciari
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

@cirospaciari 3 files with test failures on linux-x64:

  • test/cli/install/bun-run.test.ts
  • test/js/node/watch/fs.watch.test.js
  • test/js/third_party/nodemailer/nodemailer.test.ts

View test output

#88c197b3125e295c737265f2d769e1042fd60691

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

@cirospaciari 3 files with test failures on linux-x64-baseline:

  • test/cli/install/bun-run.test.ts
  • test/js/node/watch/fs.watch.test.js
  • test/js/third_party/nodemailer/nodemailer.test.ts

View test output

#88c197b3125e295c737265f2d769e1042fd60691

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

@cirospaciari 7 files with test failures on bun-darwin-aarch64:

  • test/cli/install/bun-run.test.ts
  • test/js/bun/net/socket.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/node/watch/fs.watch.test.js
  • test/js/web/fetch/fetch-leak.test.js
  • test/regression/issue/00631.test.ts

View test output

#88c197b3125e295c737265f2d769e1042fd60691

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

@cirospaciari 10 files with test failures on bun-darwin-x64-baseline:

  • test/cli/install/bun-run.test.ts
  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/bun/util/sleepSync.test.ts
  • test/js/third_party/nodemailer/nodemailer.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/fetch/fetch-leak.test.js
  • test/js/web/timers/setTimeout.test.js

View test output

#88c197b3125e295c737265f2d769e1042fd60691

@Jarred-Sumner Jarred-Sumner merged commit 979e999 into main Jul 4, 2023
15 of 20 checks passed
@Jarred-Sumner Jarred-Sumner deleted the ciro/patch-servername-tls branch July 4, 2023 22:40
@Jarred-Sumner
Copy link
Collaborator

In the future we can use .toBunString() and then server_name and then store the ZigString.Slice which would lazily become a UTF-8 string if necessary or otherwise skip the duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants